Skip to content

EXT_meshopt_compression: accessor reads use wrong byte length / stride for accessors sharing a bufferView #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camnewnham wants to merge 1 commit into
base: openupm
Choose a base branch
from
Open

EXT_meshopt_compression: accessor reads use wrong byte length / stride for accessors sharing a bufferView #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Runtime/Scripts/GltfImport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,7 +2162,8 @@ int offset
Assert.IsTrue(offset >= 0);
Assert.IsTrue(count > 0);
Assert.IsTrue(offset + count * UnsafeUtility.SizeOf(typeof(T)) <= fullSlice.Length);
return new ReadOnlyNativeArray<byte>(fullSlice).GetSubArray(offset, count).Reinterpret<T>();
// GetSubArray length is in bytes; count is an element count.
return new ReadOnlyNativeArray<byte>(fullSlice).GetSubArray(offset, count * UnsafeUtility.SizeOf(typeof(T))).Reinterpret<T>();
}
#endif
return GetAccessorData<T>(bufferView, count, offset);
Expand All @@ -2181,6 +2182,11 @@ int offset
unsafe
{
var fullSlice = m_MeshoptBufferViews[bufferViewIndex];
// Decoded meshopt data is packed at the extension's byteStride, not the
// bufferView's outer byteStride (undefined for non-vertex bufferViews).
var meshoptByteStride = bufferView.Extensions.EXT_meshopt_compression.byteStride;
if (meshoptByteStride <= 0)
meshoptByteStride = UnsafeUtility.SizeOf(typeof(T));
#if ENABLE_UNITY_COLLECTIONS_CHECKS
var safety = NativeArrayUnsafeUtility.GetAtomicSafetyHandle(fullSlice);
#endif
Expand All @@ -2189,7 +2195,7 @@ int offset
fullSlice.Length,
offset,
count,
bufferView.byteStride
meshoptByteStride
#if ENABLE_UNITY_COLLECTIONS_CHECKS
, ref safety
#endif
Expand Down