Fixes textEdit completions#101
Closed
UziTech wants to merge 3 commits into
Closed
Conversation
Member
Author
|
This should have tests to make sure it does what it is supposed to before it gets merged. |
aminya
reviewed
Jan 6, 2021
aminya
left a comment
aminya
left a comment
Member
There was a problem hiding this comment.
Would be nice to get this in too
Member
Author
|
I'm not sure this is needed. it seems like this fixes the same thing as #100 |
Member
Author
|
Ya I'm pretty sure this is already fixed unless @isundaylee can shed some light on what this fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebase of atom/atom-languageclient#254
fixes #18