Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/rovo-dev/api/rovodevStaticConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ export const RovodevStaticConfig = {
* Feature gate: rebrand "Rovo Dev" → "Jira Coding Agent" in Boysenberry environments.
* Requires both `ROVODEV_REBRAND_JCA=true` (rollout gate) and `ROVODEV_BBY=true` (Boysenberry context).
* The env var controls when the rebrand is rolled out; the BBY check ensures it only applies in Boysenberry.
* Defined as a getter so it is evaluated lazily at call time rather than once at module load.
*/
isRebrandJCA: process.env.ROVODEV_REBRAND_JCA === 'true' && process.env.ROVODEV_BBY === 'true',
get isRebrandJCA(): boolean {
return process.env.ROVODEV_REBRAND_JCA === 'true' && process.env.ROVODEV_BBY === 'true';
},
};

/**
Expand Down
6 changes: 3 additions & 3 deletions src/rovo-dev/rovoDevUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ import {

export type SupportedConfigFiles = 'config.yml' | 'mcp.json' | '.agent.md' | 'rovodev.log';

const FriendlyName: Record<SupportedConfigFiles, string> = {
const getFriendlyName = (): Record<SupportedConfigFiles, string> => ({
'config.yml': `${getProductName()} settings file`,
'mcp.json': `${getProductName()} MCP configuration`,
'.agent.md': `${getProductName()} Global Memory file`,
'rovodev.log': `${getProductName()} log file`,
};
});

// Read logging.path from ~/.rovodev/config.yml if present.
function getLogPathFromConfig(home: string): string | undefined {
Expand Down Expand Up @@ -67,7 +67,7 @@ export async function openRovoDevConfigFile(configFile: SupportedConfigFiles) {
const doc = await workspace.openTextDocument(filePath);
await window.showTextDocument(doc);
} catch (err) {
window.showErrorMessage(`Could not open ${FriendlyName[configFile]} (${filePath}): ${err}`);
window.showErrorMessage(`Could not open ${getFriendlyName()[configFile]} (${filePath}): ${err}`);
}
}

Expand Down
8 changes: 4 additions & 4 deletions src/rovo-dev/ui/rovoDevView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { RovoDevContextItem, State, ToolPermissionDialogChoice } from 'src/rovo-
import { v4 } from 'uuid';

import { DetailedSiteInfo, MinimalIssue } from '../api/extensionApiTypes';
import { RovodevStaticConfig } from '../api/rovodevStaticConfig';
import { getProductName, RovodevStaticConfig } from '../api/rovodevStaticConfig';
import {
RovoDevAgentModel,
RovoDevProviderMessage,
Expand Down Expand Up @@ -45,7 +45,7 @@ import {
ToolReturnParseResult,
} from './utils';

const DEFAULT_LOADING_MESSAGE: string = `${RovodevStaticConfig.isRebrandJCA ? 'Jira Coding Agent' : 'Rovo dev'} is working`;
const getDefaultLoadingMessage = (): string => `${getProductName()} is working`;

const RovoDevView: React.FC = () => {
const [currentState, setCurrentState] = useState<State>({ state: 'WaitingForPrompt' });
Expand Down Expand Up @@ -249,7 +249,7 @@ const RovoDevView: React.FC = () => {
switch (event.type) {
case RovoDevProviderMessageType.SignalPromptSent:
setCurrentState({ state: 'GeneratingResponse' });
setPendingToolCallMessage(DEFAULT_LOADING_MESSAGE);
setPendingToolCallMessage(getDefaultLoadingMessage());
if (event.echoMessage) {
handleAppendResponse({
event_kind: '_RovoDevUserPrompt',
Expand Down Expand Up @@ -282,7 +282,7 @@ const RovoDevView: React.FC = () => {
setPendingSubagentTasks([]);
}
} else if (last?.event_kind === 'tool-return') {
setPendingToolCallMessage(DEFAULT_LOADING_MESSAGE); // Clear pending tool call
setPendingToolCallMessage(getDefaultLoadingMessage()); // Clear pending tool call
setPendingSubagentTasks([]);
}

Expand Down
Loading