feat(response): remove class constraints to support value types#43
Merged
Conversation
e380f8b to
8e6c480
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The EndpointResponse generic types and helper methods (InvalidContentAccessException, CastContent) had where T : class
constraints that prevented generated client code from using value types like Guid, int, or DateTime as response content types. This
caused CS0452 compilation errors in projects using the source generator when an API returns a value type. This PR removes all
unnecessary class constraints across the response type hierarchy and builder interfaces.
Changes
💥 Breaking Changes
🐛 Fixes
type needed
✨ Features
📝 Documentation
✅ Tests
Notes
This is a source-compatible relaxation of constraints — all existing code using reference types continues to work unchanged. For
value type TSuccess, SuccessContent returns default(TSuccess) (e.g., Guid.Empty) on failure rather than null, since unconstrained
T? is a nullable annotation only and does not produce Nullable for value types.