Skip to content

arm64: dts: rockchip: yy3588: drop unused wifi_disable regulator#510

Merged
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:fix/yy3588-drop-wifi-disable
Jul 7, 2026
Merged

arm64: dts: rockchip: yy3588: drop unused wifi_disable regulator#510
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:fix/yy3588-drop-wifi-disable

Conversation

@SuperKali

Copy link
Copy Markdown
Member

The wifi_disable fixed regulator is never used as a supply by anything. It only holds GPIO0_C4 high at boot, and on this board that pin is not a Wi-Fi control at all.

Wi-Fi on the YY3588 is a PCIe RTL8852BE module on its own standby rail, independent of this GPIO. GPIO0_C4 is actually the eDP backlight PWM pin (pwm2_m0). The node was carried over from a radxa reference and just steals that pad.

This drops the node. Wi-Fi and Bluetooth were checked working on the board with the regulator gone.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@SuperKali, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3bf37533-ddaa-4576-88e2-6840d1094810

📥 Commits

Reviewing files that changed from the base of the PR and between ba466bc and c72481a.

📒 Files selected for processing (1)
  • arch/arm64/boot/dts/rockchip/rk3588-youyeetoo-yy3588.dts

Walkthrough

This change removes the wifi_disable fixed-regulator GPIO node (wifi-disable-gpio-regulator) from the rk3588-youyeetoo-yy3588 device tree source file. The node previously appeared after the vcc12v_dcin regulator definition. No other modifications are present.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Changes

File Change Summary
arch/arm64/boot/dts/rockchip/rk3588-youyeetoo-yy3588.dts Removed wifi_disable: wifi-disable-gpio-regulator device-tree node

Sequence Diagram(s)

Not applicable — this change is a device-tree node removal with no functional flow to diagram.

Related Issues: None referenced.

Related PRs: None referenced.

Suggested labels: dts, rockchip, rk3588

Suggested reviewers: None specified.

Poem
A rabbit hopped through the device tree,
Snipped a node it did not need to see,
No more GPIO for WiFi's disable,
The dts now leaner, clean on the table,
Hop, hop, away—simplicity!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the change: removing the unused wifi_disable regulator from the YY3588 Rockchip DTS.
Description check ✅ Passed The description is directly about removing the unused wifi_disable regulator and explains why it is safe.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The wifi_disable fixed regulator is never referenced as a supply and
does nothing but hold GPIO0_C4 high at boot. Wi-Fi on the YY3588 is a
PCIe RTL8852BE module powered from its own standby rail, independent of
this GPIO, and GPIO0_C4 is actually the eDP backlight PWM pin (pwm2_m0).
The node was inherited from a radxa reference and steals that pad, so
remove it. Wi-Fi and Bluetooth were verified working with it gone.

Signed-off-by: SuperKali <hello@superkali.me>
@SuperKali
SuperKali force-pushed the fix/yy3588-drop-wifi-disable branch from ba466bc to c72481a Compare July 7, 2026 08:46
@SuperKali
SuperKali merged commit 6e518f9 into armbian:rk-6.1-rkr5.1 Jul 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant