arm64: dts: rockchip: yy3588: drop unused wifi_disable regulator#510
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis change removes the Estimated code review effort: 1 (Trivial) | ~3 minutes Changes
Sequence Diagram(s)Not applicable — this change is a device-tree node removal with no functional flow to diagram. Related Issues: None referenced. Related PRs: None referenced. Suggested labels: dts, rockchip, rk3588 Suggested reviewers: None specified. Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The wifi_disable fixed regulator is never referenced as a supply and does nothing but hold GPIO0_C4 high at boot. Wi-Fi on the YY3588 is a PCIe RTL8852BE module powered from its own standby rail, independent of this GPIO, and GPIO0_C4 is actually the eDP backlight PWM pin (pwm2_m0). The node was inherited from a radxa reference and steals that pad, so remove it. Wi-Fi and Bluetooth were verified working with it gone. Signed-off-by: SuperKali <hello@superkali.me>
ba466bc to
c72481a
Compare
The wifi_disable fixed regulator is never used as a supply by anything. It only holds GPIO0_C4 high at boot, and on this board that pin is not a Wi-Fi control at all.
Wi-Fi on the YY3588 is a PCIe RTL8852BE module on its own standby rail, independent of this GPIO. GPIO0_C4 is actually the eDP backlight PWM pin (pwm2_m0). The node was carried over from a radxa reference and just steals that pad.
This drops the node. Wi-Fi and Bluetooth were checked working on the board with the regulator gone.