feat: add configuration file support for API key management#1
Open
lhr000lhr wants to merge 2 commits into
Open
feat: add configuration file support for API key management#1lhr000lhr wants to merge 2 commits into
lhr000lhr wants to merge 2 commits into
Conversation
- Introduced `config.json` for API key storage, with a template file `config.template.json`. - Updated `DefaultEnvInitializer.swift` to load API keys from the configuration file. - Enhanced README with instructions for using the configuration file and emphasized the importance of not committing sensitive information. - Added background mode support in `Info.plist` for audio processing. - Updated `.gitignore` to include `config.json` to prevent accidental commits.
chen-argmax
suggested changes
Aug 6, 2025
chen-argmax
left a comment
chen-argmax
left a comment
Contributor
There was a problem hiding this comment.
thanks for the change! lgtm just a couple of fields remove
| MACOSX_DEPLOYMENT_TARGET = 14.2; | ||
| MARKETING_VERSION = 0.0.1; | ||
| PRODUCT_BUNDLE_IDENTIFIER = "com.argmaxinc.example.Playground${DEVELOPMENT_TEAM}"; | ||
| "PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = com.argmaxinc.example.Playground; |
Author
There was a problem hiding this comment.
Yeah, Xcode generated this part
| DEPLOYMENT_POSTPROCESSING = NO; | ||
| DEVELOPMENT_ASSET_PATHS = "\"Playground/Preview Content\""; | ||
| DEVELOPMENT_TEAM = ""; | ||
| DEVELOPMENT_TEAM = 2A7SXV3WJH; |
Contributor
There was a problem hiding this comment.
please remove your development team :)
| MACOSX_DEPLOYMENT_TARGET = 14.2; | ||
| MARKETING_VERSION = 0.0.1; | ||
| PRODUCT_BUNDLE_IDENTIFIER = "com.argmaxinc.example.Playground${DEVELOPMENT_TEAM}"; | ||
| "PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = com.argmaxinc.example.Playground; |
| ```json | ||
| { | ||
| "apiKey": "your_actual_api_key_here", | ||
| "huggingFaceToken": null |
Contributor
There was a problem hiding this comment.
we just open sourced our huggingface repo, so huggingfacetoken is no longer needded, we can remove this field
Author
There was a problem hiding this comment.
yea I also removed huggingFaceToken form the PlainTextAPIKeyProvider now
…ration - Updated `README.md` to reflect the removal of `huggingFaceToken` from the API key configuration. - Modified `DefaultEnvInitializer.swift` to eliminate references to `huggingFaceToken` when initializing the API key provider. - Adjusted `config.template.json` to remove `huggingFaceToken` from the template structure. - Cleared `DEVELOPMENT_TEAM` entries in `project.pbxproj` for better configuration management.
chen-argmax
approved these changes
Aug 6, 2025
chen-argmax
left a comment
chen-argmax
left a comment
Contributor
There was a problem hiding this comment.
thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: API key is now loaded from config.json instead of hardcoded value