Skip to content

Add tests workflow#78

Merged
EduardoPach merged 10 commits into
mainfrom
eduardo/tests-workflow
Nov 21, 2025
Merged

Add tests workflow#78
EduardoPach merged 10 commits into
mainfrom
eduardo/tests-workflow

Conversation

@EduardoPach

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR adds CI infrastructure for automated testing and removes the Docker dependency from WDER (Word Diarization Error Rate) tests by migrating to HuggingFace-hosted test fixtures and hardcoded expected values for simple inputs.

Changes

CI Infrastructure

  • Added GitHub Actions workflow (.github/workflows/tests.yml) with two jobs:
    • Check Format: Runs Ruff linter and formatter checks
    • Run Tests: Sets up uv and executes test suite via make test
  • Workflow triggers on pull requests to main branch

Test Improvements

  • Removed Docker dependency for WDER reference implementation
    • Deleted Dockerfile and wder_reference.py that wrapped Google's diarizationlm library
    • Tests now use precomputed expected values from HuggingFace fixtures
  • Added real-world test cases:
    • test_wder_real_more_hyp_speakers: Tests with more hypothesis speakers than reference
    • test_wder_real_fewer_hyp_speakers: Tests with fewer hypothesis speakers than reference
  • Simplified test approach: Compare against expected values instead of running reference implementation
  • Test fixtures hosted at argmaxinc/test-fixtures on HuggingFace

Code Formatting

  • Applied Ruff formatting across multiple files
  • Cleaned up import ordering and line length issues
  • Reformatted long lines in whisperkitpro_engine.py, transcription_oss_whisper.py, and transcription_whisperkitpro.py

@dbrkn dbrkn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EduardoPach EduardoPach merged commit db7b78d into main Nov 21, 2025
2 checks passed
@EduardoPach EduardoPach deleted the eduardo/tests-workflow branch November 21, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants