Flag redundant allowed classes within required in the linter#1145
Merged
Conversation
rmondello
force-pushed
the
main
branch
2 times, most recently
from
July 20, 2026 21:24
4a50311 to
2643570
Compare
This will save reviewers having to catch this not uncommon mistake in the future. Example output: example.com: required: digit; allowed: digit; Redundant in `allowed:` (already covered by `required:`): digit Remove `digit` from the `allowed:` list — required classes are implicitly allowed.
7 tasks
aabosh
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will save reviewers having to catch this not uncommon mistake in the future. Example output:
example.com: required: digit; allowed: digit;
Redundant in
allowed:(already covered byrequired:): digitRemove
digitfrom theallowed:list — required classes are implicitly allowed.Overall Checklist