Remove redundant overwrite to use Java17 in pom.xml#600
Merged
Conversation
Remove redundant overwrite to use Java17, (and congrats with the new release)
Contributor
|
Hey Sebastian, thanks for the PR :) I think it's just a typo in the comment and not a redundancy. Could you double-check please? |
Contributor
Author
|
Hi @zkaoudi I just took a look at how the project is going, following a post on LinkedIn that mentioned a newer version of Java is supported. It got me curious about which one, and I looked into your POM.xml. Based on a commit from March 20, the base system is updated to use Java 17 by default: Making the overwrite to enable Java 17 redundant (unless I missed something). The specific line that made me react is: https://github.com/apache/incubator-wayang/blob/8ee427f678cfed6c12caecc84b54a3797afbb377/pom.xml#L110 |
Contributor
|
That's true, we don't need a specific profile for java 17. thanks :) |
zkaoudi
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant overwrite to use Java17, (and congrats with the new release!)