Add TimeSeriesDecisionTreeRegressionOperator#576
Conversation
zkaoudi
left a comment
There was a problem hiding this comment.
I suggest to have a generic DecisionTreeRegression operator and not tight to timeseries. Like this people who are not interested in decision trees can still use it.
We could have the emulation of creating timeseries and using decision trees in a test or application.
|
I've applied the changes as you suggested:
Please let me know if there’s anything else you'd like improved or adjusted! |
|
Hiya thanks for your contribution! I am a little confused with your usage of |
Thank you very much for the observation!
|
|
I agree with @mspruc. The operator should return the model and not Void. Also this operator should have two inputs as it's a BinaryToUnaryOperator: double[] and Double. The first one is the X (data) and the second one Y should be the labels, if I'm not mistaken. See for instance here: https://github.com/apache/incubator-wayang/blob/main/wayang-commons/wayang-basic/src/main/java/org/apache/wayang/basic/operators/LinearRegressionOperator.java Shouldn't it be a similar input/output? |
|
Hi @mspruc , @zkaoudi , thank you both for your helpful feedback!
This ensures the operator follows the same interface contract as the other regression operators in Wayang, and allows for post-training model usage. Appreciate the guidance! |
Add TimeSeriesDecisionTreeRegressionOperator with full API and integration support