Skip to content

Deps: Bump to Resolver 2.0.21#12509

Merged
cstamas merged 3 commits into
apache:masterfrom
cstamas:resolver-2021
Jul 21, 2026
Merged

Deps: Bump to Resolver 2.0.21#12509
cstamas merged 3 commits into
apache:masterfrom
cstamas:resolver-2021

Conversation

@cstamas

@cstamas cstamas commented Jul 20, 2026

Copy link
Copy Markdown
Member

And add more validation to MavenValidator.

And add more validation to MavenValidator.
@cstamas
cstamas requested a review from gnodet July 20, 2026 15:09
@cstamas cstamas self-assigned this Jul 20, 2026
@cstamas cstamas added the dependencies Pull requests that update a dependency file label Jul 20, 2026
@cstamas
cstamas marked this pull request as ready for review July 20, 2026 16:31

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean dependency bump adapting Maven 4.x (master) to the upcoming Resolver 2.0.21 API. Well-structured changes across 7 files.

What's good:

  • The Optional<Repository> return type in InternalSession.getRepository() properly handles the new ArtifactResult.NO_REPOSITORY sentinel — much cleaner than exposing the sentinel to callers
  • Good Javadoc on the getRepository() method explaining the sentinel semantics and when Optional.empty() is returned
  • Additional validation via PathUtils.validateArtifactComponents() / validateMetadataComponents() in MavenValidator hardens against path traversal — nice security improvement
  • Both RepositorySystemSupplier implementations (main + testing stubs) correctly updated with the new TransporterProvider parameter
  • All CI passing across all platforms and JDK versions

Minor note:

  • In DefaultArtifactResolver, the mappedExceptions collector uses .orElse(null) which could produce a null key in the map if NO_REPOSITORY appears in exception mappings. This is fine with HashMap semantics but worth keeping in mind if the map type ever changes.

LGTM — companion to #12504 (maven-3.10.x), this one cleanly adapts the master branch.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

@cstamas cstamas added this to the 4.1.0 milestone Jul 21, 2026
@cstamas
cstamas merged commit a2aed72 into apache:master Jul 21, 2026
22 checks passed
@cstamas
cstamas deleted the resolver-2021 branch July 21, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants