MINOR: De-duplicate Metered*WithHeaders read-only-record iterators - #22975
Open
Jess668 wants to merge 1 commit into
Open
MINOR: De-duplicate Metered*WithHeaders read-only-record iterators#22975Jess668 wants to merge 1 commit into
Jess668 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read-only-record iterators backing the headers-aware IQv2 query types (
MeteredSessionStoreWithHeaders,MeteredTimestampedWindowStoreWithHeaders,MeteredTimestampedKeyValueStoreWithHeaders) each hand-rolled the same metering lifecycle: stamping the open time, registering in numOpenIterators/openIterators, and recording the operation and iterator-duration sensors on close. Onlynext()genuinely differs per store.Extract that lifecycle into a shared
AbstractMeteredReadOnlyRecordIterator<RawKey, K, V>. Each store's iterator now extends it and implements onlynext().