MINOR: Share common implementation for downstream offset translation boundary in MirrorMaker offset syncs - #22543
Merged
Merged
Conversation
…ation boundary in MirrorMaker offset syncs
github-actions
Bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
Contributor
Author
|
Thanks @mimaison for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor to resolve the TODO in
OffsetSyncWriterby centralizing the downstream offset boundary calculation used by
MirrorMaker offset sync translation.
The existing behavior is unchanged.
OffsetSyncStoreandOffsetSyncWriternow share the same implementation inOffsetSyncinstead of duplicating the
downstreamOffset + 1logic.Reviewers: Chia-Ping Tsai
chia7712@gmail.com, Mickael Maison
mickael.maison@gmail.com