Skip to content

MINOR: Update and align broker/group config "importance" levels (KIP-848/107…#22541

Open
suzhiking wants to merge 1 commit into
apache:trunkfrom
suzhiking:kstreams-8994
Open

MINOR: Update and align broker/group config "importance" levels (KIP-848/107…#22541
suzhiking wants to merge 1 commit into
apache:trunkfrom
suzhiking:kstreams-8994

Conversation

@suzhiking

Copy link
Copy Markdown
Contributor

All the configs of KIP-848/1071/932 migrated from client side has importance level of MEDIUM. This PR updates and align config importance levels for new rebalance protocols for clients, streams, queues.

Client side has session.timeout.ms with importance level HIGH. Therefore following configs are set from MEDIUM to HIGH:

  • group.streams.session.timeout.ms
  • streams.session.timeout.ms
  • group.consumer.session.timeout.ms
  • consumer.session.timeout.ms
  • group.share.session.timeout.ms
  • share.session.timeout.ms

Client side has heartbeat.interval.ms with importance level HIGH. Therefore following configs are set from MEDIUM to HIGH:

  • group.streams.heartbeat.interval.ms
  • streams.heartbeat.interval.ms
  • group.consumer.heartbeat.interval.ms
  • consumer.heartbeat.interval.ms
  • group.share.heartbeat.interval.ms
  • share.heartbeat.interval.ms

For KIP-1071, client side has num.standby.replicas with importance level HIGH. Therefore following configs are set from MEDIUM to HIGH:

  • group.streams.num.standby.replicas
  • streams.num.standby.replicas

@github-actions github-actions Bot added triage PRs from the community group-coordinator small Small PRs labels Jun 10, 2026
@mjsax mjsax changed the title Update and align broker/group config "importance" levels (KIP-848/107… MINOR: Update and align broker/group config "importance" levels (KIP-848/107… Jun 10, 2026
@mjsax

mjsax commented Jun 10, 2026

Copy link
Copy Markdown
Member

Thanks for the PR.

One high level comment/question: for "classic" groups, there is only session.timeout.ms (which is a client side config). With the new KIPs, we get two configs, a broker config (which act as default for all groups if not overwritten), and the group config (that each group can set individually -- so this one, is "closer" to the previous client side config).

Thus, I am wondering if we should only bump the priority to HIGH for the group configs? But keep the broker one a medium?

@dajac

dajac commented Jun 11, 2026

Copy link
Copy Markdown
Member

Thanks for the PR.

Thus, I am wondering if we should only bump the priority to HIGH for the group configs? But keep the broker one a medium?

+1

@suzhiking suzhiking marked this pull request as ready for review June 11, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group-coordinator small Small PRs triage PRs from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants