MINOR: Update and align broker/group config "importance" levels (KIP-848/107…#22541
Open
suzhiking wants to merge 1 commit into
Open
MINOR: Update and align broker/group config "importance" levels (KIP-848/107…#22541suzhiking wants to merge 1 commit into
suzhiking wants to merge 1 commit into
Conversation
Member
|
Thanks for the PR. One high level comment/question: for "classic" groups, there is only Thus, I am wondering if we should only bump the priority to HIGH for the group configs? But keep the broker one a medium? |
Member
|
Thanks for the PR.
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the configs of KIP-848/1071/932 migrated from client side has importance level of
MEDIUM. This PR updates and align config importance levels for new rebalance protocols for clients, streams, queues.Client side has
session.timeout.mswith importance levelHIGH. Therefore following configs are set fromMEDIUMtoHIGH:group.streams.session.timeout.msstreams.session.timeout.msgroup.consumer.session.timeout.msconsumer.session.timeout.msgroup.share.session.timeout.msshare.session.timeout.msClient side has
heartbeat.interval.mswith importance levelHIGH. Therefore following configs are set fromMEDIUMtoHIGH:group.streams.heartbeat.interval.msstreams.heartbeat.interval.msgroup.consumer.heartbeat.interval.msconsumer.heartbeat.interval.msgroup.share.heartbeat.interval.msshare.heartbeat.interval.msFor KIP-1071, client side has
num.standby.replicaswith importance levelHIGH. Therefore following configs are set fromMEDIUMtoHIGH:group.streams.num.standby.replicasstreams.num.standby.replicas