MINOR: Clarify consumer behaviour on partition pause & re-assignments #22538
Open
lianetm wants to merge 3 commits into
Open
MINOR: Clarify consumer behaviour on partition pause & re-assignments #22538lianetm wants to merge 3 commits into
lianetm wants to merge 3 commits into
Conversation
frankvicky
approved these changes
Jun 10, 2026
frankvicky
left a comment
frankvicky
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming CI passsed
dajac
reviewed
Jun 11, 2026
Comment on lines
+1528
to
+1531
| * The eager rebalance protocol revokes all partitions on every rebalance, | ||
| * so under that protocol no pause/resume state is preserved; the cooperative rebalance protocol and | ||
| * the consumer group protocol (KIP-848) only revoke partitions that are no longer assigned, so the pause/resume | ||
| * state of partitions that remain assigned to this consumer is preserved. |
Member
There was a problem hiding this comment.
small nit: We should use the classic vs consumer language here to align with the config. I would also give example of an assignor for each sub-mode of the classic one. I don't think people really understand eager vs cooperative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify docs for pause flag behaviour when a re-assignment happens
(either manual or via rebalance). It was confusing, stating that the
flag was not preserved (it is preserved for partitions that remain
assigned + lost for partitions that move to another consumer)
Add tests to cover the behaviour for both consumers
Reviewers: TengYao Chi frankvicky@apache.org, David Jacot
david.jacot@gmail.com