Skip to content

KAFKA-20658: Cast SMT honors ByteBuffer remaining bytes #22534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BK202503 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-20658: Cast SMT honors ByteBuffer remaining bytes #22534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,10 @@ private static String castToString(Object value) {
if (value instanceof java.util.Date dateValue) {
return Values.dateFormatFor(dateValue).format(dateValue);
} else if (value instanceof ByteBuffer byteBuffer) {
return Base64.getEncoder().encodeToString(Utils.readBytes(byteBuffer));
// Utils.readBytes reads from index 0 to limit, ignoring position; use
// Utils.toArray so a sliced or partially consumed buffer is encoded
// from its current position to its limit.
return Base64.getEncoder().encodeToString(Utils.toArray(byteBuffer));
} else if (value instanceof byte[] rawBytes) {
return Base64.getEncoder().encodeToString(rawBytes);
} else {
Expand Down
17 changes: 17 additions & 0 deletions connect/transforms/src/test/java/org/apache/kafka/connect/transforms/CastTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,23 @@ public void castFieldsWithSchema() {
assertEquals(Timestamp.SCHEMA.type(), transformedSchema.field("timestamp").schema().type());
}

@Test
public void castSlicedByteBufferFieldToStringUsesRemainingBytes() {
xformValue.configure(Map.of(Cast.SPEC_CONFIG, "bytes:string"));

Schema schema = SchemaBuilder.struct()
.field("bytes", Schema.BYTES_SCHEMA)
.build();
ByteBuffer byteBuffer = ByteBuffer.wrap(new byte[] {1, 2, 3, 4});
byteBuffer.position(1);
byteBuffer.limit(3);

Struct value = new Struct(schema).put("bytes", byteBuffer);
SourceRecord transformed = xformValue.apply(new SourceRecord(null, null, "topic", 0, schema, value));

assertEquals("AgM=", ((Struct) transformed.value()).get("bytes"));
}

@SuppressWarnings("unchecked")
@Test
public void castFieldsSchemaless() {
Expand Down