fix(ci): use master Docker image for v2.5 branch only#2395
Open
ruojieranyishen wants to merge 1 commit into
Open
fix(ci): use master Docker image for v2.5 branch only#2395ruojieranyishen wants to merge 1 commit into
ruojieranyishen wants to merge 1 commit into
Conversation
Docker images like `thirdparties-bin-test-ubuntu2204-v2.5` don't exist
for release branches, causing CI startup failures.
This change uses GitHub Actions conditional expressions to use master
branch images only for v2.5 PRs, while other branches use their own
branch-specific images.
Changes:
- Updated image tags with conditional: `${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}`
- Affected jobs: Tidy, IWYU, Build/Test Release, ASAN, jemalloc, Rockylinux9
- Restored clang-tidy to compare against origin/base_ref
Notes:
- master, ci-test, *dev branches continue using their own images
- Only v2.5 (and future release branches without images) use master fallback
ruojieranyishen
changed the title
Member
|
@ruojieranyishen The image exists https://hub.docker.com/layers/apache/pegasus/thirdparties-bin-test-ubuntu2204-v2.5/images/sha256-0b03575032d07c43b10718fd9a080c6de0e3575dfcdcca015d0064684fef2da2 What kind of failure you see in CI? |
Collaborator
Author
|
Thanks for pointing out the image exists. I further checked the CI status of PR #2394: Both Cpp CI #4276 and Standardization Lint show Startup failure, not missing images.
So the issue might be related to workflow configuration or GitHub Actions permissions, not missing images. @empiredan mentioned "need to add a v2.5 image" — it would be helpful to confirm which specific image is needed, or whether the Startup failure is caused by something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI startup failures for v2.5 branch PRs that dont have prebuilt Docker images.
Problem
The workflow lint_and_test_cpp.yaml used
${{ github.base_ref }}to construct Docker image tags:apache/pegasus:thirdparties-bin-test-ubuntu2204-v2.5(doesnt exist!)This caused
startup_failurefor PRs targeting v2.5 branch.Solution
Use GitHub Actions conditional expressions to use master branch images only for v2.5 PRs:
Image tag format:
${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}Changes
ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}test-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}test-asan-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}test-jemallc-ubuntu2204-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}rockylinux9-${{ github.base_ref == 'v2.5' && 'master' || github.base_ref }}Also restored clang-tidy to compare against
origin/base_ref.Testing
The change only affects CI configuration. No code changes to C++ source.
Related
This fix enables CI for cherry-pick PRs targeting v2.5 branch.