Skip to content

[MINOR][CH] Correct misleading Spark 3.2 comment in ReadBufferBuilder #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuciferYang wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

[MINOR][CH] Correct misleading Spark 3.2 comment in ReadBufferBuilder #12583

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887b62f
[MINOR][CH] Correct misleading Spark 3.2 comment in ReadBufferBuilder
LuciferYang Jul 21, 2026
8cccb46
[MINOR] Reword ReadBufferBuilder fallback comment for accuracy
LuciferYang Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cpp-ch/local-engine/Storages/SubstraitSource/ReadBufferBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,9 @@ class HDFSFileReadBufferBuilder : public ReadBufferBuilder
{
if (!file_size.has_value())
{
// only for spark3.2 file partition not contained file size
// so first compute file size first
// Fallback for callers whose Substrait LocalFilesNode was built without a
// fileSize list (e.g. some Iceberg producers). Compute the size by opening
// the HDFS file first.
Comment thread
LuciferYang marked this conversation as resolved.
Outdated
auto tmp_read_buffer = std::make_unique<DB::ReadBufferFromHDFS>(
hdfs_uri,
hdfs_file_path,
Expand Down
Loading