Skip to content

[FLINK-38647][CDC] Improve error message for null before/after struct… #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuxiqian merged 8 commits into from
Jul 15, 2026
Merged

[FLINK-38647][CDC] Improve error message for null before/after struct… #4439

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24ae529
[FLINK-38647][CDC] Improve error message for null before/after struct…
BreadS00 Jun 8, 2026
a15a8d3
Normalize null-before hint and drop trailing space
BreadS00 Jun 15, 2026
2c4510d
Merge branch 'apache:master' into master
BreadS00 Jul 10, 2026
425fd56
Merge branch 'apache:master' into master
BreadS00 Jul 13, 2026
01ef76b
Move REPLICA IDENTITY hint to PostgresEventDeserializer, use Precondi…
BreadS00 Jul 13, 2026
55f584b
Merge remote-tracking branch 'origin/master'
BreadS00 Jul 13, 2026
b50c85c
Some cases and adjustments
BreadS00 Jul 14, 2026
2d983c0
update
BreadS00 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .../main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresEventDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@
package org.apache.flink.cdc.connectors.postgres.source;

import org.apache.flink.cdc.common.annotation.Internal;
import org.apache.flink.cdc.common.data.RecordData;
import org.apache.flink.cdc.common.data.binary.BinaryStringData;
import org.apache.flink.cdc.common.event.SchemaChangeEvent;
import org.apache.flink.cdc.common.event.TableId;
import org.apache.flink.cdc.connectors.postgres.table.PostgreSQLReadableMetadata;
import org.apache.flink.cdc.debezium.event.DebeziumEventDeserializationSchema;
import org.apache.flink.cdc.debezium.table.DebeziumChangelogMode;
import org.apache.flink.table.data.TimestampData;
import org.apache.flink.util.Preconditions;

import com.fasterxml.jackson.databind.ObjectMapper;
import io.debezium.data.Envelope;
Expand Down Expand Up @@ -83,6 +85,19 @@ public PostgresEventDeserializer(
this.databaseName = databaseName;
}

@Override
protected RecordData extractBeforeDataRecord(Struct value, Schema valueSchema)
throws Exception {
Struct beforeValue = fieldStruct(value, Envelope.FieldName.BEFORE);
Preconditions.checkNotNull(
beforeValue,
"Before data is null for UPDATE/DELETE event. "
+ "This usually happens when the source table is not configured with "
+ "REPLICA IDENTITY FULL. Schema name: "
+ valueSchema.name());
return super.extractBeforeDataRecord(value, valueSchema);
}
Comment thread
BreadS00 marked this conversation as resolved.

Comment thread
BreadS00 marked this conversation as resolved.
@Override
protected List<SchemaChangeEvent> deserializeSchemaChangeRecord(SourceRecord record) {
return Collections.emptyList();
Expand Down
11 changes: 10 additions & 1 deletion ...src/main/java/org/apache/flink/cdc/debezium/event/DebeziumEventDeserializationSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import org.apache.flink.cdc.runtime.typeutils.BinaryRecordDataGenerator;
import org.apache.flink.cdc.runtime.typeutils.EventTypeInfo;
import org.apache.flink.util.Collector;
import org.apache.flink.util.Preconditions;

import io.debezium.data.Envelope;
import io.debezium.data.SpecialValueDecimal;
Expand Down Expand Up @@ -141,15 +142,23 @@ public TypeInformation<Event> getProducedType() {
return new EventTypeInfo();
}

private RecordData extractBeforeDataRecord(Struct value, Schema valueSchema) throws Exception {
protected RecordData extractBeforeDataRecord(Struct value, Schema valueSchema)
throws Exception {
Schema beforeSchema = fieldSchema(valueSchema, Envelope.FieldName.BEFORE);
Struct beforeValue = fieldStruct(value, Envelope.FieldName.BEFORE);
Preconditions.checkNotNull(
beforeValue,
"Before data is null for UPDATE/DELETE event. Schema name: " + valueSchema.name());
return extractDataRecord(beforeValue, beforeSchema);
}

private RecordData extractAfterDataRecord(Struct value, Schema valueSchema) throws Exception {
Schema afterSchema = fieldSchema(valueSchema, Envelope.FieldName.AFTER);
Struct afterValue = fieldStruct(value, Envelope.FieldName.AFTER);
Preconditions.checkNotNull(
afterValue,
"After data is null for CREATE/READ/UPDATE event. Schema name: "
+ valueSchema.name());
Comment thread
yuxiqian marked this conversation as resolved.
Outdated
return extractDataRecord(afterValue, afterSchema);
}

Expand Down