Skip to content

GH-48740: [C++] Add missing CTypeTraits for decimal types #50153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Naurder wants to merge 3 commits into
base: main
Choose a base branch
from
+34 −0
Open

GH-48740: [C++] Add missing CTypeTraits for decimal types #50153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0678222
GH-48740: [C++] Add missing CTypeTraits for decimal types
Naurder Jun 10, 2026
c1e0955
apply reviewer suggestion: inherit from TypeTraits
Naurder Jun 11, 2026
220a94b
Address review comments: move CTypeTraits, add Dec32/64 and tests
Naurder Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cpp/src/arrow/type_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1493,6 +1493,20 @@ PRIMITIVE_TEST(DoubleType, double, DOUBLE, "double");

PRIMITIVE_TEST(BooleanType, bool, BOOL, "bool");

TEST(TypesTest, DecimalTraits) {
static_assert(std::is_same_v<TypeTraits<Decimal32Type>::CType, Decimal32>);
static_assert(std::is_same_v<CTypeTraits<Decimal32>::ArrowType, Decimal32Type>);

static_assert(std::is_same_v<TypeTraits<Decimal64Type>::CType, Decimal64>);
static_assert(std::is_same_v<CTypeTraits<Decimal64>::ArrowType, Decimal64Type>);

static_assert(std::is_same_v<TypeTraits<Decimal128Type>::CType, Decimal128>);
static_assert(std::is_same_v<CTypeTraits<Decimal128>::ArrowType, Decimal128Type>);

static_assert(std::is_same_v<TypeTraits<Decimal256Type>::CType, Decimal256>);
static_assert(std::is_same_v<CTypeTraits<Decimal256>::ArrowType, Decimal256Type>);
}

TEST(TestBinaryType, ToString) {
BinaryType t1;
BinaryType e1;
Expand Down
20 changes: 20 additions & 0 deletions cpp/src/arrow/type_traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,26 @@ struct TypeTraits<Decimal256Type> {
constexpr static bool is_parameter_free = false;
};

template <>
struct CTypeTraits<Decimal32> : TypeTraits<Decimal32Type> {
using ArrowType = Decimal32Type;
};

template <>
struct CTypeTraits<Decimal64> : TypeTraits<Decimal64Type> {
using ArrowType = Decimal64Type;
};

template <>
struct CTypeTraits<Decimal128> : TypeTraits<Decimal128Type> {
using ArrowType = Decimal128Type;
};

template <>
struct CTypeTraits<Decimal256> : TypeTraits<Decimal256Type> {
using ArrowType = Decimal256Type;
};

template <>
struct TypeTraits<BinaryType> {
using ArrayType = BinaryArray;
Expand Down