🧹 Refactor: Extract ConnectionManager from RelayServer#38
Conversation
Extracted WebSocket routing, message tracking, and connection handling from `RelayServer` into a new `ConnectionManager` class. This improves maintainability and aligns the monolithic server class with the Single Responsibility Principle. All functionality remains equivalent and tests continue to pass. Co-authored-by: anusornc <11565019+anusornc@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🎯 What: Extracted the monolithic WebSocket message handling, socket tracking, and agent routing logic from
RelayServer(src/relay/server.ts) into a dedicatedConnectionManagerclass insrc/relay/connection-manager.ts.💡 Why:
RelayServerhad grown to over 800 lines and was responsible for both HTTP/S server lifecycles, REST handler initialization, and low-level WebSocket connection tracking and request promises. This refactor splits those concerns, dramatically reducing the file size and improving code organization and readability.✅ Verification: Validated that the code compiles via
npx tsc --noEmitand successfully passes the integration test suite (npx vitest run test/relay). Confirmed types are still exported properly to prevent breakages.✨ Result: Improved separation of concerns, reduced file bloat, and highly maintainable components.
PR created automatically by Jules for task 5381095481387524851 started by @anusornc