refactor: move errors related code into separate file - #4554
Merged
qwerty541 merged 2 commits intoOct 9, 2025
Merged
Conversation
|
@qwerty541 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
qwerty541
approved these changes
Oct 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error-related code by extracting error classes and constants from the common utilities module into a dedicated error module. This improves code organization and separation of concerns.
- Moves
CustomErrorandMissingParamErrorclasses fromutils.jsto newerror.jsfile - Updates all import statements across the codebase to reference the new error module
- Adds TypeScript type hints and improves documentation in some files
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/error.js | New file containing extracted error classes and constants |
| src/common/utils.js | Removes error-related code and imports from new error module |
| src/common/index.js | Updates exports to remove error classes |
| src/common/retryer.js | Updates imports and adds TypeScript annotations |
| src/fetchers/*.js | Updates imports to use new error module location |
| src/cards/stats.js | Updates import statement for CustomError |
| tests/renderStatsCard.test.js | Updates import statement for CustomError |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
qwerty541
deleted the
refactor_move_errs_related_code_into_separate_file
branch
October 9, 2025 19:31
Mzalimouza
approved these changes
Oct 11, 2025
harryzcy
pushed a commit
to harryzcy/github-readme-stats
that referenced
this pull request
Oct 15, 2025
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
martin-mfg
pushed a commit
to stats-organization/github-stats-extended
that referenced
this pull request
Nov 2, 2025
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
ghosind
pushed a commit
to ghosind/github-readme-stats
that referenced
this pull request
Dec 30, 2025
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
zimya
pushed a commit
to zimya/github-readme-stats-cf
that referenced
this pull request
Jan 13, 2026
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
piscis
pushed a commit
to piscis/github-readme-stats
that referenced
this pull request
Feb 7, 2026
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
zntb
added a commit
to zntb/github-readme-stats
that referenced
this pull request
Jul 27, 2026
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
zntb
added a commit
to zntb/github-readme-stats
that referenced
this pull request
Jul 27, 2026
* refactor: move errors related code into separate file * jsdoc --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.