Skip to content

fix(xlsx): handle missing AF_UNIX in recalc shim check - #1183

Open
superShen0916 wants to merge 1 commit into
anthropics:mainfrom
superShen0916:fix/xlsx-af-unix-guard
Open

fix(xlsx): handle missing AF_UNIX in recalc shim check#1183
superShen0916 wants to merge 1 commit into
anthropics:mainfrom
superShen0916:fix/xlsx-af-unix-guard

Conversation

@superShen0916

Copy link
Copy Markdown

Summary

  • Return false from the LibreOffice shim check when the Python socket module does not expose AF_UNIX
  • Add a focused regression test for Windows builds where AF_UNIX is unavailable

Fixes #1120

Test plan

  • python3 skills/xlsx/scripts/office/test_soffice.py
  • python3 -m py_compile skills/xlsx/scripts/office/soffice.py skills/xlsx/scripts/office/test_soffice.py

Note: I also tried unittest discovery under skills/xlsx/scripts/office, but it imports validators that require defusedxml, which is not installed in this local environment.

Signed-off-by: superShen0916 <superShen0916@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xlsx recalc.py crashes on Windows: unguarded socket.AF_UNIX access

1 participant