fix(string): preserve falsy variable values in template()#56
Open
maxtaran2010 wants to merge 1 commit into
Open
fix(string): preserve falsy variable values in template()#56maxtaran2010 wants to merge 1 commit into
maxtaran2010 wants to merge 1 commit into
Conversation
…le values `vars[key] || fallback` incorrectly falls through to the fallback when a variable is explicitly set to a falsy value like 0, false, or "". Switch to `key in vars ? vars[key] : fallback` so only missing keys trigger the fallback, not legitimate falsy values. Adds test cases for 0, false, and "" to prevent regression. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
antfu
reviewed
Jul 14, 2026
| if (isObject(firstArg)) { | ||
| const vars = firstArg as Record<string, any> | ||
| return str.replace(/\{(\w+)\}/g, (_, key) => vars[key] || ((typeof fallback === 'function' ? fallback(key) : fallback) ?? key)) | ||
| return str.replace(/\{(\w+)\}/g, (_, key) => key in vars ? vars[key] : ((typeof fallback === 'function' ? fallback(key) : fallback) ?? key)) |
Owner
There was a problem hiding this comment.
Instead of in, let's use "hasOwn" to be safer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
template()function usesvars[key] || fallbackwhen doing named substitution, which causes it to fall through to the fallback value whenever a variable is explicitly set to a falsy value —0,false, or"".Buggy behavior:
Fix
Replace
vars[key] || fallbackwithkey in vars ? vars[key] : fallbackso only keys that are actually absent fromvarstrigger the fallback, not keys that are present but hold a falsy value.Test plan
0,false, and""values in named template modepnpm test— 39 tests passing)