Skip to content

Bucket eventbridge notifications#6866

Open
yotamishak wants to merge 2 commits into
anomalyco:devfrom
yotamishak:bucket-eventbridge-notifications
Open

Bucket eventbridge notifications#6866
yotamishak wants to merge 2 commits into
anomalyco:devfrom
yotamishak:bucket-eventbridge-notifications

Conversation

@yotamishak
Copy link
Copy Markdown
Contributor

added support for the eventbridge notification + abstraction on bucket to subscribe to these events directly

main "limitation" on aws side, eventbridge notifications need to be configure together direct sqs/sns/lambda notification in order to prevent overriding bucket configuration

leaving comments on questionable decisions
let me know if anything needs fixing/or drop abstractions

* A list of subscribers that'll be notified when events happen in the bucket.
*/
notifications: Input<
notifications?: Input<
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed this to optional, allowing only to pass eventbridge true

defaults to empty array uptop

| "Object Tags Added"
| "Object Tags Deleted"
| "Object ACL Updated"
| string
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be closed list, but left room for error just incase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant