read Svg preview off the main Thread#21344
Open
Phoenix1808 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
When previewing a selected SVG in the multimedia image editor, the
SVG file is read on the main thread (loadSvgFromUri -> openInputStream
-> convertToString) before it's passed to the WebView. For a large SVG
or a slow document provider, this read can briefly block the UI.
This moves the read to Dispatchers.IO and keeps the WebView update on
the main thread. Behaviour is unchanged.
Fixes #21276
How Has This Been Tested?
Manually previewed SVG and non-SVG images in the multimedia image
editor; the preview renders as before.
:AnkiDroid:compilePlayDebugKotlinbuilds cleanly.
I didn't add an automated test: this is a threading change with no
observable behaviour difference, and there isn't existing infrastructure
to assert main-thread usage here. Happy to add one if you'd prefer a
specific approach.