refactor: use backend 'Day/Night/Follow system' strings#21325
Open
david-allison wants to merge 1 commit into
Open
refactor: use backend 'Day/Night/Follow system' strings#21325david-allison wants to merge 1 commit into
david-allison wants to merge 1 commit into
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
fde4d50 to
78f3994
Compare
`string-array` values are moved to enums, as these XML files cannot accommodate `TR` calls. Assisted-by: Claude Opus 4.8
78f3994 to
63828b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.8
Purpose / Description
Moves 3 difficult strings to the backend
Approach
string-arrayvalues are moved to enums, as these XML files cannot accommodateTRcalls.Then move all values to have the enum as the source of truth, and drive the preferences from them.
"Follow system" needed SentenceCase, so also handle this
How Has This Been Tested?
Visually inspected the 'Appearance' screen
Checklist