fix: use full namespaced name for db search PURLs#3531
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
grype db search --pkg only used purl.Name when building the package specifier from a PURL. For ecosystems that carry part of the name in the PURL namespace this drops the rest of the name, so the search never matches. A golang module PURL like pkg:golang/github.com/gin-gonic/gin was searched as just "gin" instead of github.com/gin-gonic/gin. Reconstruct the stored name per ecosystem: golang and npm join namespace/name, Maven joins groupId:artifactId, everything else keeps purl.Name. This mirrors the openvex build transformer so search and the data side agree on the name. Fixes anchore#3508 Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3508.
grype db search --pkgwith a golang PURL doesn't match because the package specifier is built frompurl.Nameonly. For ecosystems that carry part of the name in the PURL namespace, that drops the rest of the name. Sopkg:golang/github.com/gin-gonic/gingets searched as justgin, and nothing matches (the DB keys the record under the full module pathgithub.com/gin-gonic/gin).This adds an ecosystem-aware
packageNameFromPURLinPostLoadthat reconstructs the stored name:namespace/name(e.g.github.com/gin-gonic/gin,@babel/core)groupId:artifactIdpurl.Name(unchanged behavior for flat-namespaced ecosystems)It's the same reconstruction the openvex build transformer already does (
grype/db/v6/build/transformers/openvex), so the search side and the data side now agree on the name. I extended it to cover golang since that's what the issue hit.Testing
Added table cases to
TestDBSearchPackagesPostLoadfor the golang module path, npm scope, and Maven group:artifact mappings (the plain-name fallback was already covered).