Skip to content

feat(project-management): add meeting-analyzer and team-communication… - #457

Merged
alirezarezvani merged 1 commit into
devfrom
feat/community-skills-448
Mar 31, 2026
Merged

feat(project-management): add meeting-analyzer and team-communication…#457
alirezarezvani merged 1 commit into
devfrom
feat/community-skills-448

Conversation

@alirezarezvani

Copy link
Copy Markdown
Owner

…s skills

Based on PR #438 by maximcoding. Enhanced with anti-patterns, cross-references, attribution, and renamed examples/ → references/.

meeting-analyzer (254 lines):

  • Transcript analysis: speaking dynamics, conflict detection, filler words, decision patterns, facilitation quality, active listening
  • Supports .txt, .md, .vtt, .srt, .docx, .json formats
  • Trend tracking across multiple meetings

team-communications (67 lines + 4 reference templates):

  • Internal comms: 3P updates, newsletters, FAQ roundups, general comms
  • 4 reference templates with exact formatting guides
  • MCP integration (Slack, Gmail, Drive, Calendar) when available

Summary

Checklist

  • Target branch is dev (not main — PRs to main will be auto-closed)
  • Skill has SKILL.md with valid YAML frontmatter (name, description, license)
  • Scripts (if any) run with --help without errors
  • No hardcoded API keys, tokens, or secrets
  • No vendor-locked dependencies without open-source fallback
  • Follows existing directory structure (domain/skill-name/SKILL.md)

Type of Change

  • New skill
  • Improvement to existing skill
  • Bug fix
  • Documentation
  • Infrastructure / CI

Testing

…s skills

Based on PR #438 by maximcoding. Enhanced with anti-patterns, cross-references,
attribution, and renamed examples/ → references/.

meeting-analyzer (254 lines):
- Transcript analysis: speaking dynamics, conflict detection, filler words,
  decision patterns, facilitation quality, active listening
- Supports .txt, .md, .vtt, .srt, .docx, .json formats
- Trend tracking across multiple meetings

team-communications (67 lines + 4 reference templates):
- Internal comms: 3P updates, newsletters, FAQ roundups, general comms
- 4 reference templates with exact formatting guides
- MCP integration (Slack, Gmail, Drive, Calendar) when available

Co-Authored-By: maximcoding <maximcoding@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alirezarezvani
alirezarezvani merged commit cacb578 into dev Mar 31, 2026
3 of 4 checks passed
@alirezarezvani
alirezarezvani deleted the feat/community-skills-448 branch March 31, 2026 13:16
@claude

claude Bot commented Mar 31, 2026

Copy link
Copy Markdown

Code Review — PR #457: meeting-analyzer + team-communications

Note: This PR is already merged. Leaving this review for future reference and follow-up.

Both skills are well-structured additions to the PM domain. The modular analysis design (independent modules in meeting-analyzer) and clear routing table in team-communications are strong patterns. Attribution to the original contributor (maximcoding) is appreciated. A few issues to address in a follow-up:


Bugs / Correctness

3p-updates.md — incorrect tense in description (line ~766 in diff)

"what the team has accomplished over the next time period"

Should be "over the past time period." This is in the Progress section, which covers past work, not future plans.

company-newsletter.md — typo

"perhgaps referencing emails"

Should be perhaps.

index.md — broken attribution link

> Originally contributed by maximcoding(https://github.com/maximcoding) — ...

Missing markdown link syntax. Should be:

> Originally contributed by [maximcoding](https://github.com/maximcoding) — ...

Formatting / Standards

Missing newline at end of file — affects 5 of the 7 new files:

  • project-management/meeting-analyzer/SKILL.md
  • project-management/team-communications/SKILL.md
  • project-management/team-communications/references/3p-updates.md
  • project-management/team-communications/references/faq-answers.md
  • project-management/team-communications/references/general-comms.md

general-comms.md — unexpected leading indent
The ## Instructions header and all body lines have 2-space leading indentation. This is inconsistent with the other reference files and will render oddly in some Markdown parsers.

YAML frontmatter missing license field
Both SKILL.md files have name and description but not license. The PR checklist explicitly requires Skill has SKILL.md with valid YAML frontmatter (name, description, license).


Skill Package Structure

Per the pattern in CLAUDE.md, skills should include:

skill-name/
├── SKILL.md
├── scripts/   ← missing in both skills
├── references/ ← present in team-communications, absent in meeting-analyzer
└── assets/    ← missing in both skills
  • meeting-analyzer has no references/ or scripts/ directories. Adding even a single Python script (e.g., a transcript file inventory/stats tool) would make this skill executable and follow the library pattern.
  • team-communications has references/ (good!) but no scripts/ or assets/ (user-facing templates).

This is lower priority since documentation-only skills can still be valuable, but the package pattern exists for a reason.


What's Working Well

  • The meeting-analyzer module breakdown (Speaking Dynamics, Conflict & Directness, Filler Words, Question Quality, Facilitation, Sentiment) is thorough and well-reasoned.
  • Anti-patterns tables in both skills are excellent — specific, actionable, and non-obvious.
  • Edge case handling in meeting-analyzer (no speaker labels, short meetings, non-English, single meeting) is production-ready.
  • The routing table in team-communications is clean and avoids ambiguity well.
  • mkdocs.yml and docs index updates are correct.
  • Cross-skill Related Skills tables add real navigational value.

Suggested follow-up PR: Fix the tense bug in 3p-updates.md, the typo in company-newsletter.md, the broken attribution link in index.md, add missing newlines, add license to YAML frontmatter in both SKILL.md files, and fix the indent in general-comms.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant