Skip to content

Dev - #395

Merged
alirezarezvani merged 17 commits into
mainfrom
dev
Mar 23, 2026
Merged

Dev#395
alirezarezvani merged 17 commits into
mainfrom
dev

Conversation

@alirezarezvani

Copy link
Copy Markdown
Owner

Summary

Checklist

  • Target branch is dev (not main — PRs to main will be auto-closed)
  • Skill has SKILL.md with valid YAML frontmatter (name, description, license)
  • Scripts (if any) run with --help without errors
  • No hardcoded API keys, tokens, or secrets
  • No vendor-locked dependencies without open-source fallback
  • Follows existing directory structure (domain/skill-name/SKILL.md)

Type of Change

  • New skill
  • Improvement to existing skill
  • Bug fix
  • Documentation
  • Infrastructure / CI

Testing

Leo and others added 17 commits March 18, 2026 08:20
- Add plugin.json for review-fix-a11y skill
- Add plugin.json for free-llm-api skill
- Restore POSIX-compliant trailing newlines in JSON index files
…ix) (#375)

Adds review-fix-a11y (WCAG 2.2 a11y audit + fix) and free-llm-api skills.

Includes:
- review-fix-a11y: WCAG 2.2 audit workflow, a11y_audit.py scanner, contrast_checker.py
- free-llm-api: ChatAnywhere, Groq, Cerebras, OpenRouter, llm-mux, One API setup
- secret_scanner.py upgrade with secrets-patterns-db integration (1,600+ patterns)

Co-authored-by: ivanopenclaw223-alt <ivanopenclaw223-alt@users.noreply.github.com>
… audit & fix (#376)

Built from scratch (replaces reverted PR #375 contribution).

Skill package:
- SKILL.md: 1132 lines, 3-phase workflow (scan → fix → verify),
  per-framework fix patterns (React, Next.js, Vue, Angular, Svelte, HTML),
  CI/CD integration guide, 20+ issue type coverage
- scripts/a11y_scanner.py: static scanner detecting 20+ violation types
  across HTML/JSX/TSX/Vue/Svelte/CSS — severity-ranked, CI-friendly exit codes
- scripts/contrast_checker.py: WCAG contrast calculator with AA/AAA checks,
  --suggest mode, --batch CSS scanning, named color support
- references/wcag-quick-ref.md: WCAG 2.2 Level A/AA criteria table
- references/aria-patterns.md: ARIA roles, live regions, keyboard interaction
- references/framework-a11y-patterns.md: React, Vue, Angular, Svelte fix patterns
- assets/sample-component.tsx: sample file with intentional violations
- expected_outputs/: scan report, contrast output, JSON output samples
- /a11y-audit slash command, settings.json, plugin.json, README.md

Validation: 97.6/100 (EXCELLENT), quality 73.9/100 (B-), scripts 2/2 PASS

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…s, 22 plugins

Update CLAUDE.md, README.md, docs/index.md, docs/getting-started.md,
mkdocs.yml, marketplace.json with consistent counts. Sync Gemini CLI
index with new skills (code-to-prd, plugin-audit).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Added to marketplace:
- a11y-audit (WCAG 2.2 accessibility audit)
- executive-mentor (adversarial thinking partner)
- docker-development (Dockerfile, compose, multi-stage)
- helm-chart-builder (Helm chart scaffolding)
- terraform-patterns (IaC module design)
- research-summarizer (structured research synthesis)

Also fixed version 1.0.0 → 2.1.2 on 4 plugin.json files
(executive-mentor, docker-development, helm-chart-builder, research-summarizer)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…umentation

- 7 phases: discovery → meta tags → content quality → keywords → links → sitemap → report
- Integrates 8 marketing-skill scripts: seo_checker, content_scorer,
  humanizer_scorer, headline_scorer, seo_optimizer, sitemap_analyzer,
  schema_validator, topic_cluster_mapper
- References 6 SEO knowledge bases for audit framework, AI search,
  content optimization, URL design, internal linking, AI detection
- Auto-fixes: generic titles, missing descriptions, broken links, orphan pages
- Preserves high-ranking pages — only fixes critical issues on those
- Registered in both commands/ (distributable) and .claude/commands/ (local)

Also: sync all doc counts — 28 plugins, 26 eng-core skills, 21 commands

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…to nav

- generate-docs.py: extract_description_from_frontmatter() now handles
  multi-line YAML block scalars (|, >, indented continuation) — fixes
  14 pages that had 56-65 char truncated descriptions
- mkdocs.yml: add epic-design and research-summarizer to nav (orphan pages)
- Regenerated 251 pages, rebuilt sitemap (278 URLs)
- SEO audit: 0 broken links, 17→3 short descriptions, 278/278 pages
  have "Claude Code Skills" in <title>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Claude Code plugin manifest requires author as {"name": "..."}, not a
plain string. Fixes install error: "author: Invalid input: expected
object, received string"

Affected: agenthub, a11y-audit

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rdize counts

Cherry-picked from PR #387 (ssmanji89) and rebased on dev.

- Fix 6 wrong PM skill install paths in INSTALLATION.md
- Fix content-creator → content-production script paths
- Fix senior-devops CLI flags to match actual deployment_manager.py
- Replace vague descriptions with trigger-oriented "Use when..." on 7 engineering skills
- Standardize skill count 170 → 205+, finance 1 → 2, version 2.1.1 → 2.1.2
- Use python3 instead of python for macOS compatibility
- Remove broken integrations/ link in README.md

Excluded: *.zip gitignore wildcard (overrides intentional design decision)

Co-Authored-By: sully <ssmanji89@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The GSC verification HTML file existed locally but was never committed,
so it was never deployed to GitHub Pages. This caused GSC to fail
reading the sitemap for 3+ weeks ("Sitemap konnte nicht gelesen werden").

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alirezarezvani
alirezarezvani merged commit 17228ef into main Mar 23, 2026
1 check passed
@claude

claude Bot commented Mar 23, 2026

Copy link
Copy Markdown

PR Review — Dev → Main (#395)

Summary: This PR ships the a11y-audit engineering skill, the seo-auditor slash command, marketplace registrations for 6 skills, improved Codex descriptions, and documentation/installation fixes.


✅ Strengths

  • a11y-audit skill is well-structured — full SKILL.md, two Python scripts (a11y_scanner.py, contrast_checker.py), scripts/, references/, assets/, and expected_outputs/ follow the standard skill package pattern cleanly.
  • Codex descriptions improved — the 6 updated entries in .codex/skills-index.json now use actionable "Use when the user asks to…" format, which is a meaningful usability improvement for agent routing.
  • seo-auditor command is thorough — the 7-phase structure (Discovery → Meta Tags → Content Quality → Keywords → Links → Sitemap → Report) is clear and actionable. Good use of existing marketing-skill/ scripts rather than re-implementing logic.
  • pythonpython3 fixes in INSTALLATION.md — correct and necessary for modern systems.
  • Gemini CLI symlinks for a11y-audit and cmd-a11y-audit properly follow the existing symlink pattern.

⚠️ Issues to Address

1. SKILL.md frontmatter has duplicate/mixed-case fields

engineering-team/a11y-audit/SKILL.md lines 1–12 contain both legacy uppercase keys (Name:, Tier:, Category:) and the required lowercase keys (name:, description:, license:). While the checklist fields are present, the duplicate keys are messy and could confuse parsers. The legacy uppercase block should be removed — lowercase fields alone are sufficient.

2. a11y-audit plugin.json has an extra url field in author

engineering-team/a11y-audit/.claude-plugin/plugin.json includes "url": "https://alirezarezvani.com" inside the author object. Per CLAUDE.md ClawHub constraints: "ONLY these fields: name, description, version, author, homepage, repository, license, skills" — no extra fields allowed. The url inside author is an extra field. Other plugin.json files in this repo (e.g. executive-mentor) use only "name" inside author.

3. executive-mentor plugin.json missing homepage and repository

c-level-advisor/executive-mentor/.claude-plugin/plugin.json doesn't include homepage or repository fields. The a11y-audit plugin.json includes both. While these are optional, consistency across plugin.json files is recommended for marketplace quality.

4. Marketplace entries added without corresponding new skill content

marketplace.json adds four skills that don't have new content in this PR: docker-development, helm-chart-builder, terraform-patterns, research-summarizer. These presumably already existed — if so, this is fine, but worth confirming the source paths resolve and the skills are production-ready for marketplace listing.

5. PR checklist is entirely unchecked

All items in the PR template checklist (SKILL.md frontmatter, --help verification, no secrets, etc.) are unchecked. For a PR landing in main, it's good hygiene to confirm these explicitly before merging.


📝 Minor Notes

  • docs/googlec3db22c96191d971.html is a Google Search Console verification file — intentional and fine, just noting it's now committed to the repo.
  • commands/seo-auditor.md and .claude/commands/seo-auditor.md both exist. The commands/ copy is the canonical slash command; .claude/commands/ is the Claude Code-specific location. This dual-location pattern appears consistent with how a11y-audit.md is handled, so it's fine.
  • CLAUDE.md still says "19 commands" in the architecture overview (commands/ # 19 slash commands) but the .gemini/skills-index.json count bumped to 20. The CLAUDE.md line should be updated to 20.

Summary

The a11y-audit skill is the main addition and it's solid. The critical fix needed before or after merge is removing the duplicate uppercase frontmatter block from SKILL.md and removing the url field from author in the plugin.json to comply with the ClawHub schema constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants