Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 43 additions & 4 deletions .codex/skills-index.json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Engineering category count still shows 19 instead of 24 after adding 5 new engineering skills

The categories.engineering.count field at .codex/skills-index.json:383 was not updated. It still says 19, but the skills array now contains 24 engineering-category skills (19 original + tech-debt-tracker + api-design-reviewer + interview-system-designer + migration-architect + observability-designer).

Root Cause and Impact

The total_skills field was correctly updated from 54 to 59, but the per-category count for engineering was left at 19. You can verify this:

  • Actual engineering skills in array: 24
  • Declared in categories.engineering.count: 19
  • Sum of all category counts: 54 (should be 59)

This means total_skills (59) ≠ sum of category counts (54), breaking the internal consistency of the index.

Impact: Any consumer summing category counts to validate the total will see a mismatch. Dashboards or reports using per-category counts will undercount engineering skills.

(Refers to line 383)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "claude-code-skills",
"description": "Production-ready skill packages for AI agents - Marketing, Engineering, Product, C-Level, PM, and RA/QM",
"repository": "https://github.com/alirezarezvani/claude-skills",
"total_skills": 54,
"total_skills": 59,
"skills": [
{
"name": "customer-success-manager",
Expand Down Expand Up @@ -51,7 +51,31 @@
"name": "incident-commander",
"source": "../../engineering-team/incident-commander",
"category": "engineering",
"description": "Skill from engineering-team"
"description": "Incident response playbook with severity classification, timeline reconstruction, and post-incident review generation. Includes automated severity classification, timeline reconstruction from logs, PIR generation with RCA frameworks, and communication templates for stakeholder updates."
},
{
"name": "tech-debt-tracker",
"source": "../../engineering/tech-debt-tracker",
"category": "engineering",
"description": "Codebase debt analysis with AST parsing, prioritization frameworks, and trend dashboards. Automatically identifies tech debt signals, analyzes cost-of-delay, and tracks debt trends over time with executive reporting capabilities."
},
{
"name": "api-design-reviewer",
"source": "../../engineering/api-design-reviewer",
"category": "engineering",
"description": "REST/OpenAPI linting, breaking change detection, and API design scorecards. Validates API conventions, detects compatibility issues, scores design quality, and ensures security best practices for REST APIs."
},
{
"name": "interview-system-designer",
"source": "../../engineering/interview-system-designer",
"category": "engineering",
"description": "Calibrated interview loops, question banks, and hiring calibration analysis. Designs role-specific interview processes, generates competency-based questions, and provides bias analysis with standardized evaluation frameworks."
},
{
"name": "migration-architect",
"source": "../../engineering/migration-architect",
"category": "engineering",
"description": "Zero-downtime migration planning, compatibility checking, and rollback generation. Plans phased migrations, validates schema compatibility, generates rollback procedures, and provides risk assessment for complex system migrations."
},
{
"name": "ms365-tenant-manager",
Expand Down Expand Up @@ -328,6 +352,20 @@
"source": "../../ra-qm-team/risk-management-specialist",
"category": "ra-qm",
"description": "Medical device risk management specialist implementing ISO 14971 throughout product lifecycle. Provides risk analysis, risk evaluation, risk control, and post-production information analysis."
},
{
"name": "observability-designer",
"path": "engineering/observability-designer",
"category": "engineering",
"tier": "POWERFUL",
"description": "SLI/SLO frameworks, alert optimization, and dashboard generation for production observability.",
"scripts": [
"slo_designer.py",
"alert_optimizer.py",
"dashboard_generator.py"
],
"references": true,
"assets": true
Comment on lines +357 to +368

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 observability-designer uses path key instead of source, breaking schema consistency

The observability-designer entry in the skills index uses "path" as the key for its location, while all other 58 skills use "source". It also uses a completely different schema with extra fields (tier, scripts, references, assets) and a different path format (no ../../ prefix).

Root Cause and Impact

All 58 other skills follow this schema:

{"name": "...", "source": "../../engineering-team/...", "category": "...", "description": "..."}

But the observability-designer entry at .codex/skills-index.json:357-368 uses:

{"name": "observability-designer", "path": "engineering/observability-designer", "category": "engineering", "tier": "POWERFUL", ...}

Any tooling or scripts that iterate over d['skills'] and access skill['source'] will get a KeyError for this entry. The path format (engineering/observability-designer) is also inconsistent with the ../../ relative path convention used by every other skill (e.g., ../../engineering-team/incident-commander).

Impact: Breaks automated processing of the skills index; any consumer expecting the uniform source field will fail on this entry.

Suggested change
"name": "observability-designer",
"path": "engineering/observability-designer",
"category": "engineering",
"tier": "POWERFUL",
"description": "SLI/SLO frameworks, alert optimization, and dashboard generation for production observability.",
"scripts": [
"slo_designer.py",
"alert_optimizer.py",
"dashboard_generator.py"
],
"references": true,
"assets": true
"name": "observability-designer",
"source": "../../engineering/observability-designer",
"category": "engineering",
"description": "SLI/SLO frameworks, alert optimization, and dashboard generation for production observability."
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
],
"categories": {
Expand Down Expand Up @@ -371,5 +409,6 @@
"source": "../../ra-qm-team",
"description": "Regulatory affairs and quality management skills"
}
}
}
},
"total": 59

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Redundant total field added alongside existing total_skills field

A new "total": 59 field was added at the bottom of the JSON (.codex/skills-index.json:413) while the existing "total_skills": 59 field already exists at line 6. This creates two competing sources of truth for the same value.

Root Cause and Impact

The original schema uses total_skills at .codex/skills-index.json:6. The new total field at line 413 is a duplicate with a different key name. If these values ever diverge during a future update (one gets updated, the other doesn't), consumers won't know which to trust.

Impact: Schema pollution and potential for future inconsistency between total_skills and total.

Prompt for agents
Remove the redundant "total": 59 field at the end of .codex/skills-index.json (line 413). The existing "total_skills": 59 field at line 6 already serves this purpose. The closing of the JSON object should go back to just a closing brace after the categories object, changing line 412 from '  },' back to '  }' and removing line 413.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
16 changes: 13 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,28 @@ All notable changes to the Claude Skills Library will be documented in this file
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [Unreleased] - 2026-02-16

### Added
- **incident-commander** (POWERFUL tier) — Incident response playbook with severity classifier, timeline reconstructor, and PIR generator
- **tech-debt-tracker** (POWERFUL tier) — Codebase debt scanner with AST parsing, debt prioritizer, and trend dashboard
- **api-design-reviewer** (POWERFUL tier) — REST API linter, breaking change detector, and API design scorecard
- **interview-system-designer** (POWERFUL tier) — Interview loop designer, question bank generator, and hiring calibrator
- **migration-architect** (POWERFUL tier) — Migration planner, compatibility checker, and rollback generator
- **observability-designer** (POWERFUL tier) — SLO designer, alert optimizer, and dashboard generator
- `campaign-analytics` - Multi-touch attribution, funnel conversion, campaign ROI (3 Python tools)
- `customer-success-manager` - Onboarding, retention, expansion, health scoring (2 Python tools)
- `sales-engineer` - Technical sales, solution design, RFP responses (2 Python tools)
- `revenue-operations` - Pipeline analytics, forecasting, process optimization (2 Python tools)
- `financial-analyst` - DCF valuation, budgeting, forecasting, financial modeling (3 Python tools)
- New `business-growth` domain with 3 skills
- New `finance` domain with 1 skill
- 87+ Python automation tools (up from 68+)
- 53 total skills across 8 domains (up from 48 across 6)
- 92+ Python automation tools (up from 87+, including 17 new POWERFUL-tier tools)
- 58 total skills across 8 domains (up from 53)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 CHANGELOG says 58 total skills but README badge and JSON index both say 59

The CHANGELOG entry at CHANGELOG.md:25 states "58 total skills across 8 domains" but the README badge at README.md:9 was updated to 59, and .codex/skills-index.json contains 59 skill entries with total_skills: 59.

Detailed Explanation

The PR adds 5 new skills (incident-commander description update, tech-debt-tracker, api-design-reviewer, interview-system-designer, migration-architect) plus observability-designer — totaling 6 new entries (54 → 59 after adding the observability-designer in a separate commit). The CHANGELOG appears to have been written when only 4 new skills were planned (54 → 58), but the actual final count is 59.

This creates conflicting information for users reading the release notes vs. the README badge or the JSON index.

Impact: Documentation inconsistency that confuses users about the actual number of available skills.

Suggested change
- 58 total skills across 8 domains (up from 53)
- 59 total skills across 8 domains (up from 53)
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


### Fixed
- CI workflows (smart-sync.yml, pr-issue-auto-close.yml) — PR #193
- Installation documentation (Issue #189) — PR #193

### Planned
- Complete Anthropic best practices refactoring (37/42 skills remaining)
Expand Down
104 changes: 103 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![Claude AI](https://img.shields.io/badge/Claude-AI-blue.svg)](https://claude.ai)
[![Claude Code](https://img.shields.io/badge/Claude-Code-purple.svg)](https://claude.ai/code)
[![Multi-Agent Compatible](https://img.shields.io/badge/Multi--Agent-Compatible-green.svg)](https://github.com/skillcreatorai/Ai-Agent-Skills)
[![53 Skills](https://img.shields.io/badge/Skills-53-brightgreen.svg)](#-available-skills)
[![59 Skills](https://img.shields.io/badge/Skills-59-brightgreen.svg)](#-available-skills)
[![SkillCheck Validated](https://img.shields.io/badge/SkillCheck-Validated-4c1)](https://getskillcheck.com)

---
Expand Down Expand Up @@ -800,6 +800,108 @@ Data pipeline engineering, ETL/ELT workflows, and data infrastructure.

---

#### 🚨 Incident Commander
**Status:** ✅ Production Ready | **Version:** 1.0

Incident response playbook with severity classification, timeline reconstruction, and post-incident review generation.

**What's Included:**
- **Incident Classifier** - Severity analysis and response team recommendations (Python CLI)
- **Timeline Reconstructor** - Chronological incident timeline reconstruction (Python CLI)
- **PIR Generator** - Comprehensive post-incident review generation (Python CLI)
- **Severity Classifier** - Automated incident severity assessment (Python CLI)
- **Timeline Builder** - Incident event timeline construction (Python CLI)
- **Postmortem Generator** - Structured postmortem documentation (Python CLI)

**Learn More:** [engineering-team/incident-commander/SKILL.md](engineering-team/incident-commander/SKILL.md)

---

#### 📊 Tech Debt Tracker
**Status:** ✅ Production Ready | **Version:** 1.0

Codebase debt analysis with AST parsing, prioritization frameworks, and trend dashboards.

**What's Included:**
- **Debt Scanner** - Automated technical debt detection with AST parsing (Python CLI)
- **Debt Prioritizer** - Cost-of-delay analysis and debt prioritization (Python CLI)
- **Debt Dashboard** - Trend tracking and executive reporting dashboard (Python CLI)
- **Code Quality Analysis** - Comprehensive codebase health assessment
- **Architecture Debt Detection** - Structural and design debt identification
- **Maintenance Cost Modeling** - Financial impact analysis of technical debt

**Learn More:** [engineering/tech-debt-tracker/SKILL.md](engineering/tech-debt-tracker/SKILL.md)

---

#### 🔌 API Design Reviewer
**Status:** ✅ Production Ready | **Version:** 1.0

REST/OpenAPI linting, breaking change detection, and API design scorecards.

**What's Included:**
- **API Linter** - REST convention validation and best practices enforcement (Python CLI)
- **Breaking Change Detector** - Automated API compatibility analysis (Python CLI)
- **API Scorecard** - Comprehensive design quality assessment (Python CLI)
- **OpenAPI Validation** - Schema compliance and documentation checking
- **Security Assessment** - Authentication, authorization, and security headers review
- **Performance Analysis** - Caching, pagination, and efficiency pattern evaluation

**Learn More:** [engineering/api-design-reviewer/SKILL.md](engineering/api-design-reviewer/SKILL.md)

---

#### 🎯 Interview System Designer
**Status:** ✅ Production Ready | **Version:** 1.0

Calibrated interview loops, question banks, and hiring calibration analysis.

**What's Included:**
- **Loop Designer** - Role-specific interview process design (Python CLI)
- **Question Bank Generator** - Competency-based question generation (Python CLI)
- **Hiring Calibrator** - Interview bias analysis and calibration tools (Python CLI)
- **Competency Matrices** - Skills assessment framework development
- **Scoring Rubrics** - Standardized evaluation criteria creation
- **Bias Mitigation** - Interview process fairness optimization

**Learn More:** [engineering/interview-system-designer/SKILL.md](engineering/interview-system-designer/SKILL.md)

---

#### 🚀 Migration Architect
**Status:** ✅ Production Ready | **Version:** 1.0

Zero-downtime migration planning, compatibility checking, and rollback generation.

**What's Included:**
- **Migration Planner** - Phased migration strategy generation (Python CLI)
- **Compatibility Checker** - Schema and API compatibility validation (Python CLI)
- **Rollback Generator** - Automated rollback procedure creation (Python CLI)
- **Risk Assessment** - Migration failure point identification
- **Timeline Estimation** - Resource-based migration scheduling
- **Data Validation** - Cross-system data integrity verification

**Learn More:** [engineering/migration-architect/SKILL.md](engineering/migration-architect/SKILL.md)

---

#### 📡 Observability Designer
**Status:** ✅ Production Ready | **Version:** 1.0

SLI/SLO frameworks, alert optimization, and dashboard generation for production observability.

**What's Included:**
- **SLO Designer** - Generate SLI definitions, SLO targets, error budgets, and burn rate alerts (Python CLI)
- **Alert Optimizer** - Analyze alert configs for noise, coverage gaps, duplicates, and fatigue risks (Python CLI)
- **Dashboard Generator** - Create role-based dashboard specs with golden signals and RED/USE methods (Python CLI)
- **SLO Cookbook** - Comprehensive SLO implementation guide
- **Alert Design Patterns** - Battle-tested alerting strategies
- **Dashboard Best Practices** - Visualization and layout principles

**Learn More:** [engineering/observability-designer/SKILL.md](engineering/observability-designer/SKILL.md)

---

#### 🤖 Senior ML/AI Engineer
**Status:** ✅ Production Ready | **Version:** 1.0

Expand Down
Loading
Loading