fix(docker/rocky): drop dnf update -y to avoid breaking the CUDA toolkit#2147
Merged
Conversation
…olkit The final `dnf update -y` in the deps image upgraded packages from the CUDA repo, pulling cccl-13.3 which obsoletes cuda-cccl-12-1 and makes cuda-cudart-devel-12-1 (from the 12.1.1 base image) uninstallable: package cccl-13-3 obsoletes cuda-cccl-12-1 provided by cuda-cccl-12-1 cannot install the best update candidate for cuda-cudart-devel-12-1 The dependency build then fails at the system-package step. Drop the blanket update so the CUDA toolkit shipped in the base image stays consistent; the needed packages are already pinned via the explicit dnf install lists above.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the docker/Dockerfile_rocky_deps file to remove the dnf update -y command from the package installation step. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
cbentejac
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Rocky deps image ends its system-package step with a blanket
dnf update -y. That upgrade pulls packages from the CUDA repo and nowbreaks dependency resolution against the CUDA 12.1.1 base image:
NVIDIA published
cccl-13.x(CUDA 13) in the repo;dnf update -ytries tomove CUDA packages to it, conflicting with the 12.1 toolkit that ships in the
base image. The build fails at this step (STEP 6/21).
Fix
Drop the blanket
dnf update -y. The packages the build needs are alreadyinstalled explicitly via the
dnf installlists just above, and the CUDAtoolkit from the base image is left untouched and consistent.