Skip to content

fix(cmake): don't use GIT_SHALLOW when a dependency is pinned to a commit #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
servantftransperfect merged 1 commit into from
Jun 26, 2026
Merged

fix(cmake): don't use GIT_SHALLOW when a dependency is pinned to a commit #2146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/cmake/Helpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,12 @@ macro(av_add_cmake_dep)
if(_D_GIT_TAG)
list(APPEND _D_SRC_ARGS GIT_TAG ${_D_GIT_TAG})
endif()
# Shallow clone : plus rapide, économise le réseau
list(APPEND _D_SRC_ARGS GIT_SHALLOW TRUE)
# Shallow clone only fetches the default-branch tip: a GIT_TAG that is
# a commit hash not at that tip fails to check out. Use it only for
# named refs (branches/tags), not for pinned commits.
if(NOT "${_D_GIT_TAG}" MATCHES "^[0-9a-fA-F]+$")
list(APPEND _D_SRC_ARGS GIT_SHALLOW TRUE)
endif()
endif()

ExternalProject_Add(${_D_TARGET}
Expand Down
Loading