Skip to content

[sfm] Add new parameters to the SfM process#1912

Merged
cbentejac merged 3 commits into
developfrom
dev/sfmParameters
Jul 28, 2025
Merged

[sfm] Add new parameters to the SfM process#1912
cbentejac merged 3 commits into
developfrom
dev/sfmParameters

Conversation

@servantftransperfect

Copy link
Copy Markdown
Contributor
  • Add a new hard threshold for minimal angle in initial pair selection (The current minimal angle is only heavily reducing the score of the pair with the low angle).
  • Triangulation reprojection error (To discard observation for a given triangulated point) is available as a public parameter.
  • Triangulation reprojection error is now dependent on the feature scale (the higher the scale, the higher the tolerance) <-- This may create algorithm behavior change !

CedricThebault
CedricThebault previously approved these changes Jul 23, 2025

@CedricThebault CedricThebault left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to be able to disable the residual error weighting, but I acknowledge that it would require a lot of changes to expose it up to the node, whereas commenting a single line of code can achieve the same.

@cbentejac cbentejac changed the title [sfm] Adding parameters to sfm process [sfm] Add new parameters to SfM process Jul 28, 2025
@cbentejac cbentejac changed the title [sfm] Add new parameters to SfM process [sfm] Add new parameters to the SfM process Jul 28, 2025
@cbentejac cbentejac merged commit a2c32bd into develop Jul 28, 2025
4 checks passed
@cbentejac cbentejac deleted the dev/sfmParameters branch July 28, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants