[sfm] Add new parameters to the SfM process#1912
Merged
Merged
Conversation
servantftransperfect
commented
Jul 11, 2025
Contributor
- Add a new hard threshold for minimal angle in initial pair selection (The current minimal angle is only heavily reducing the score of the pair with the low angle).
- Triangulation reprojection error (To discard observation for a given triangulated point) is available as a public parameter.
- Triangulation reprojection error is now dependent on the feature scale (the higher the scale, the higher the tolerance) <-- This may create algorithm behavior change !
5b13489 to
7cbf3ac
Compare
CedricThebault
previously approved these changes
Jul 23, 2025
CedricThebault
left a comment
Member
There was a problem hiding this comment.
It would be nice to be able to disable the residual error weighting, but I acknowledge that it would require a lot of changes to expose it up to the node, whereas commenting a single line of code can achieve the same.
49e22a6 to
32a7e79
Compare
32a7e79 to
072b35f
Compare
cbentejac
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.