patch for #777: harden original CID accounting per review feedback#780
Closed
Yanmei-Liu wants to merge 1 commit into
Closed
patch for #777: harden original CID accounting per review feedback#780Yanmei-Liu wants to merge 1 commit into
Yanmei-Liu wants to merge 1 commit into
Conversation
- Add idempotency guard to xqc_cid_set_mark_original to prevent double-counting if called multiple times on the same CID - Exclude original_cid_cnt from sender-side supply check in xqc_conn_try_add_new_conn_id so we issue the correct number of NCIDs - Handle original_cid_cnt decrement in xqc_cid_set_delete_cid path - Fix missing trailing newlines in test files
Yanmei-Liu
changed the title
Yanmei-Liu
changed the title
Collaborator
Author
|
Close. Fix at original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixup for #777 — addresses review feedback on the handshake CID exclusion implementation:
xqc_cid_set_mark_originalnow checks!inner->is_originalbefore incrementing counter, preventing silent inflation if called twice on the same CIDxqc_conn_try_add_new_conn_idnow subtractsoriginal_cid_cntin all threewhileconditions, so the endpoint correctly issues up toactive_connection_id_limitnon-handshake CIDsxqc_cid_set_delete_cidnow decrementsoriginal_cid_cntwhen removing an active original CIDxqc_cid_test.candxqc_cid_test.hTest plan
xqc_test_cid_handshake_exclusionpasses (no behavioral regression — guard only activates on double-call which doesn't occur in current tests)xqc_test_cid_active_limitpasses (sender-side change is consistent with receiver-side fix)sh scripts/xquic_test.shFixes review comments on #777.