fix: correct timeStrCache calculation to exclude unmatched trailing chars#2557
Open
Snssn wants to merge 1 commit into
Open
fix: correct timeStrCache calculation to exclude unmatched trailing chars#2557Snssn wants to merge 1 commit into
Snssn wants to merge 1 commit into
Conversation
|
senyong.wang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…hars Use strptimeResult position (actual matched end) instead of curTimeStr.length() when building the second-level cache. This fixes cache pollution when the time string contains trailing characters not matched by the format string (e.g. timezone suffix +08:00). Also add unit test to verify the fix.
Collaborator
|
百炼自动化审查:建议保持开启。 本 PR 修复了 ProcessorParseTimestampNative 中时间字符串二级缓存键计算的缺陷,改用 strptime 实际匹配结束位置计算缓存长度以避免尾部未匹配字符导致的缓存污染,并补充了单元测试。因贡献者尚未签署 CLA 且等待维护者审查与 CI 验证,建议保持开启。. 最佳落地路径: 保持开启。等待贡献者完成 CLA 签署,维护者审查代码变更(重点验证 cacheLen 指针差值计算在各类边界条件下的安全性)及 CI 全量验证通过后合并至 main。. 已核对内容:
百炼审查备注:模型 qwen3.6-max-preview;对照提交 8b91144f8a81。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strptimeResult position (actual matched end) instead of curTimeStr.length()
when building the second-level cache. This fixes cache pollution when the time
string contains trailing characters not matched by the format string (e.g. timezone suffix +08:00)