feat(sight): add unit tests for http endpoint and domain rule parsing#631
Merged
Merged
Conversation
chengshuyi
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests covering the HTTP target configuration parsing logic:
test_load_json_http_endpoint: validates endpoint parsing for:portandip:portformatstest_load_json_http_domain: validates domain rule parsing including exact match and wildcard patternsRelated Issue
closes #630
Type of Change
Scope
sight(agentsight)Checklist
sight:cargo testpassCargo.lock)Testing
cargo test --lib— all tests pass including the two new test cases.