Skip to content

feat(sight): add unit tests for http endpoint and domain rule parsing#631

Merged
chengshuyi merged 1 commit into
alibaba:mainfrom
Daydreamer-Li:feat/sight/http-config
May 27, 2026
Merged

feat(sight): add unit tests for http endpoint and domain rule parsing#631
chengshuyi merged 1 commit into
alibaba:mainfrom
Daydreamer-Li:feat/sight/http-config

Conversation

@Daydreamer-Li

Copy link
Copy Markdown
Collaborator

Description

Add unit tests covering the HTTP target configuration parsing logic:

  • test_load_json_http_endpoint: validates endpoint parsing for :port and ip:port formats
  • test_load_json_http_domain: validates domain rule parsing including exact match and wildcard patterns

Related Issue

closes #630

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional change)
  • Performance improvement
  • CI/CD or build changes

Scope

  • sight (agentsight)

Checklist

  • I have read the Contributing Guide
  • My code follows the project's code style
  • I have added tests that prove my fix is effective or that my feature works
  • For sight: cargo test pass
  • Lock files are up to date (Cargo.lock)

Testing

cargo test --lib — all tests pass including the two new test cases.

@Daydreamer-Li Daydreamer-Li requested a review from chengshuyi as a code owner May 27, 2026 02:30
@Daydreamer-Li Daydreamer-Li requested a review from samchu-zsl May 27, 2026 02:30
@github-actions github-actions Bot added the component:sight src/agentsight/ label May 27, 2026
@Daydreamer-Li Daydreamer-Li changed the title test(sight): add unit tests for http endpoint and domain rule parsing feat(sight): add unit tests for http endpoint and domain rule parsing May 27, 2026
@chengshuyi chengshuyi merged commit bd8625d into alibaba:main May 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:sight src/agentsight/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sight] test(sight): add unit tests for http endpoint and domain rule parsing

2 participants