Merge Caches with Backends - #1011
Conversation
sakosha
changed the title
MemoryBackend into MemoryCache, MemcachedBackend into MemcachedCache
There was a problem hiding this comment.
It'd be good to have the relevant changes separately from the typing changes...
There was a problem hiding this comment.
Should we also omit the **kwargs TODO?
# Conflicts: # aiocache/backends/valkey.py
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| key: bytes, | ||
| encoding: str = "utf-8", | ||
| _conn: Union[_Conn, None] = None, | ||
| ) -> Union[str, None]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| @overload | ||
| async def _get( | ||
| self, key: bytes, encoding: None, _conn: Union[_Conn, None] = None | ||
| ) -> Union[bytes, None]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| keys: Iterable[bytes], | ||
| encoding: str = "utf-8", | ||
| _conn: Union[_Conn, None] = None, | ||
| ) -> list[Union[str, None]]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| keys: Iterable[bytes], | ||
| encoding: None, | ||
| _conn: Union[_Conn, None] = None, | ||
| ) -> list[Union[bytes, None]]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| key: str, | ||
| encoding: str = "utf-8", | ||
| _conn: Union[_Conn, None] = None, | ||
| ) -> Union[str, None]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| @overload | ||
| async def _get( | ||
| self, key: str, encoding: None, _conn: Union[_Conn, None] = None | ||
| ) -> Union[bytes, None]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| keys: list[str], | ||
| encoding: str = "utf-8", | ||
| _conn: Union[_Conn, None] = None, | ||
| ) -> list[Union[str, None]]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| keys: list[str], | ||
| encoding: None, | ||
| _conn: Union[_Conn, None] = None, | ||
| ) -> list[Union[bytes, None]]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
superseded by #1024 |
3 participants
What do these changes do?
MemoryBackendw/MemoryCache.MemcachedBackendw/MemcachedCache.ValkeyBackendw/ValkeyCache....Cache.Are there changes in behavior for the user?
Backendclasses removed.typing-extensionsnow a required dependency before 3.11Related issue number
Fixes #684
Checklist