fix(service): validate subagent HITL confirm against worker SSOT and cascade interrupt - #2327
Open
REISEN2330 wants to merge 1 commit into
Open
fix(service): validate subagent HITL confirm against worker SSOT and cascade interrupt#2327REISEN2330 wants to merge 1 commit into
REISEN2330 wants to merge 1 commit into
Conversation
…cascade interrupt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2324
What
Two guards around the subagent HITL confirm loop:
POST /chat's confirm-routing branch now checks the worker's SSOT(
_worker_still_asking) before enqueueing the resume. When the workeris no longer parked on the ASKING tool call, the stale card is cleared
(projection delete +
subagent_user_confirm_resultpublish) and theendpoint returns 409 — so the front-end stops re-posting the same
UserConfirmResultEvent(previously 437x) instead of spinning forever.POST /sessions/{id}/interruptnow cascades to team members: parkedHITL runs are interrupted via resume triggers carrying
UserInterruptEvent, and their projected cards are purged, so thecard can no longer survive an interrupt.
Verification
pre-commit run --all-filescleanpytest tests/chat_router_hitl_test.py -v— 3 new regression tests passpytest tests/hitl_user_confirmation_test.py tests/service_subagent_hitl_projector_test.py -q— 16 pass