Skip to content

test(ci): allow slower Windows Hub cold starts - #7273

Merged
rayrayraykk merged 1 commit into
agentscope-ai:mainfrom
rayrayraykk:fix/windows-hub-e2e-startup-timeout
Aug 25, 2026
Merged

test(ci): allow slower Windows Hub cold starts#7273
rayrayraykk merged 1 commit into
agentscope-ai:mainfrom
rayrayraykk:fix/windows-hub-e2e-startup-timeout

Conversation

@rayrayraykk

Copy link
Copy Markdown
Member

Description

Increase the Hub readiness budget in the packaged Local runtime E2E test from 60 to 120 seconds.

The failing Windows job completed all 7,962 unit tests, then timed out while waiting for the packaged Hub process to bind. The child process remained alive and its log stopped after CLI startup, so the final WinError 10061 was the last readiness probe rather than a port-binding failure. Historical successful Windows runs of the same E2E took about 110 and 132 seconds end to end, which shows that the previous 60-second Hub cold-start budget was too tight on hosted Windows runners.

This keeps the real Windows E2E enabled and preserves hard failures when the Hub process exits or does not become ready within the expanded budget. It does not xfail or suppress product errors.

Related Issue: Relates to #7268

Security Considerations: None. This changes only an E2E readiness deadline.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Core / Backend (app, agents, config, providers, utils, local_models)
  • Console (frontend web UI)
  • Channels (DingTalk, Lark, QQ, Discord, iMessage, etc.)
  • Skills
  • CLI
  • Documentation (website)
  • Tests
  • CI/CD
  • Scripts / Deploy

Checklist

  • I ran pre-commit run --all-files locally and it passes
  • If pre-commit auto-fixed files, I committed those changes and reran checks
  • I ran tests locally (pytest or as relevant) and they pass
  • Documentation updated (not needed)
  • Ready for review

For Channel Changes (DingTalk, Lark, QQ, Console, etc.)

  • I ran ./scripts/check-channels.sh (or ./scripts/check-channels.sh --changed) and it passes
  • Contract test exists in tests/contract/channels/test_<channel>_contract.py (REQUIRED)
  • Contract test implements create_instance() with proper channel initialization
  • All 19 contract verification points pass (see tests/contract/channels/__init__.py)
  • Optional: Unit tests in tests/unit/channels/test_<channel>.py for complex internal logic

Testing

Run the packaged Hub Local runtime E2E on the Python 3.11 Windows matrix entry. The test must still start the Hub, register a user, start an isolated Local runtime, proxy its health endpoint, and stop the runtime successfully.

Evidence

QWENPAW_LOCAL_RUNTIME_E2E=1 pytest tests/e2e/test_hub_local_runtime.py -v
1 passed in 8.58s

pre-commit run --files tests/e2e/test_hub_local_runtime.py
check python ast.........................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Passed
pylint...................................................................Passed

Failing Windows job: https://github.com/agentscope-ai/QwenPaw/actions/runs/32817133090/job/97711270532

Historical successful Windows E2E: https://github.com/agentscope-ai/QwenPaw/actions/runs/32465714880/job/96721841254

Additional Notes

This is intentionally separate from #7268 because the failure is pre-existing Windows CI timing behavior and is unrelated to the heartbeat source-timeout change.

Copilot AI lite review requested due to automatic review settings August 25, 2026 07:18
@github-project-automation github-project-automation Bot moved this to Todo in QwenPaw Aug 25, 2026
@github-actions

Copy link
Copy Markdown

Welcome to QwenPaw! 🐾

Hi @rayrayraykk, this is your 263rd Pull Request.

🙌 Join Developer Community

Thanks so much for your contribution! We'd love to invite you to join the official QwenPaw developer group! You can find the Discord and DingTalk group links under the "Developer Community" section on our docs page:
https://qwenpaw.agentscope.io/docs/community

We truly appreciate your enthusiasm—and look forward to your future contributions! 😊

We'll review your PR soon.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the packaged Hub Local runtime E2E test to better tolerate slower Hub cold starts on hosted Windows runners by expanding the Hub readiness wait budget, while still failing if the Hub process exits or never becomes ready.

Changes:

  • Introduces a named constant for Hub readiness timeout.
  • Increases Hub readiness deadline from 60s to 120s by using the new constant.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lalaliat lalaliat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayrayraykk
rayrayraykk merged commit 9e2724f into agentscope-ai:main Aug 25, 2026
30 of 31 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in QwenPaw Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants