Skip to content

Fix login error message #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VansYoMans merged 2 commits into from
Jul 10, 2026
Merged

Fix login error message #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5707ff
Add no lowercase username error message
VansYoMans Jul 8, 2026
2d86c35
compile translation and merge login error messages
VansYoMans Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sipa/blueprints/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,11 @@ def login():
logger.info("Authentication failed: Wrong %s", cause, extra={
'tags': {'user': username, 'rate_critical': True}
})
flash(gettext("Anmeldedaten fehlerhaft!"), "error")
if not username.islower():
flash(gettext("Anmeldedaten fehlerhaft oder Benutzername muss kleingeschrieben werden!"), "error")
else:
flash(gettext("Anmeldedaten fehlerhaft!"), "error")

else:
if isinstance(user, User):
login_user(user, remember=remember)
Expand Down
Binary file modified sipa/translations/de/LC_MESSAGES/messages.mo
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions sipa/translations/de/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,9 @@ msgstr ""
msgid "Anmeldedaten fehlerhaft!"
msgstr ""

msgid "Anmeldedaten fehlerhaft oder Benutzername muss kleingeschrieben werden!"
msgstr ""

msgid "Anmeldung erfolgreich!"
msgstr ""

Expand Down
Binary file modified sipa/translations/en/LC_MESSAGES/messages.mo
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions sipa/translations/en/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,9 @@ msgstr "Error during communication with the backend server ('%(name)s')"
msgid "Anmeldedaten fehlerhaft!"
msgstr "Authentication data incorrect!"

msgid "Anmeldedaten fehlerhaft oder Benutzername muss kleingeschrieben werden!"
msgstr "Authentication data incorrect or username has to be written in lowercase"

msgid "Anmeldung erfolgreich!"
msgstr "Authentication successful!"

Expand Down
Loading