fix(binanceFinalizer): Handle non-standard USDC symbol for ZKUSDCE - #3263
Conversation
ZkSync deposited USDC does not use USDC as the internal symbol
This is to include the new Arweave gateway logic. --------- Signed-off-by: bennett <bennett@umaproject.org>
The TVM RPC interface is extremely constrained vs. other EVM implementations. Many features don't work, notably event subscriptions. Trying to support this within the existing EVM listener was proving invasive, so spin the TVM-specific implementation out separately. This allows risk-free iterations to mature the code. We still hold out hope that it might one day be unified with the EVM implementation. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
withdrawMax is typically a very large number (e.g. 200mil for USDT) so converting it to a source token involves finding the price at which it would execute in the orderbook which triggers errors complaining that the whole orderbook has been traversed. I believe keeping the withdrawMax check in this code is useful so its safer to convert the `amountToTransfer`, which is capped by our own `maxAmountToTransfer` config variable, to destination token precision. This is an equivalent conversion it just should never trigger this same error related to insufficient orderbook depth
💡 Codex ReviewLines 91 to 95 in d0e099e  Keep backward-compatible Arweave gateway env parsing
This change only reads ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
ZkSync deposited USDC does not use USDC as the internal symbol