Chat rework#170
Draft
bqv wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
|
bqv
force-pushed
the
malkovitch
branch
3 times, most recently
from
eaff5b3 to
e95d79a
Compare
Owner
|
Oh yeah, receiving variations in chat is definitely something that I'd like to add, thank you for looking into it! I'm not so sure about malkovich chat though, people will just be confused at what that does and is IMHO an anti-feature. But if it's there already let's include it and see how many people complain about it. :) |
bqv
force-pushed
the
malkovitch
branch
2 times, most recently
from
c2f154e to
bce965a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beginnings of sending game chat of different types, and receiving all the different kinds of message.
Variations format now, and clicking them jumps into analysis mode with the move tree
Sending variations works when chat is opened from analysis mode
Bots that send using the GameChatTranslatedMessage type now parse and display properly
Reviews will format and clicking them will open the review as a URL (thoughts: review fragment?)
Relatively half baked at the moment. It works, besides the boards not displaying properly because I can't quite think of a neat way to walk up the move history in ChatDialog. Sending variations will also always use the MAIN channel because I misinterpreted how that works and need to rework the UI design, thoughts on that would be appreciated
Lastly, There's a strange bug I unearthed while doing this. Malkovich chat appears fine at the end of a game, but if you then reenter the game later, it doesn't always reliably appear, and I'm not sure what could cause that. Am I missing something or is that a true bug, and on what side?