feat(verification): add Mermaid support for Docker-based verification#268
Merged
Conversation
- Introduced Mermaid as a new target in the Docker verification setup. - Updated package.json and Dockerfiles to include Mermaid dependencies and configuration. - Added a new validation test for Mermaid diagrams to ensure proper parsing. - Enhanced the verification manifest to include Mermaid as a target. This commit expands the verification capabilities to include Mermaid, ensuring a consistent environment for testing and validation. Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>
- Added jsdom and mermaid as new dependencies. - Included @antfu/install-pkg and @asamuzakjp/css-color with their respective dependencies. - Updated several other packages to their latest versions. This commit enhances the project by incorporating additional libraries and ensuring up-to-date dependencies for improved functionality. Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>
Contributor
Author
|
@DianaLease @ekarademir Review for this PR whenever possible( but a little quick :)) |
mttrbrts
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Mermaid to the Docker verification pipeline so generated
.mmddiagrams from the corpus are syntax-checked in CI and locally, consistent with other codegen targets.Changes
verification/docker/targets.jsonwithMermaidCLI target andmermaid.parsevalidation tool.verification/docker/mermaid/) that generates diagrams viarun-case.shand validates each.mmdwithmermaid.parse(viajsdomfor Node DOM APIs).verification/docker/mermaid/validate.jswith a sharedparseMermaid()helper used by both Docker and unit tests.test/verification/mermaid.validate.test.jsto run corpus cases throughMermaidVisitorand assert every generated.mmdparses.verify-codegen.ymlmatrix,scripts/verification/docker-run.jstargets list, andverify:docker:mermaidnpm script.mermaid@11.12.0andjsdom@25.0.1as devDependencies for local test validation.Flags
jsdomenvironment before callingmermaid.parse.mermaidandjsdomunder/opt/mermaid-verify(next tovalidate.js) so ESM import resolution works;NODE_PATHalone is insufficient for ESM.package.jsondevDependencies.Author Checklist
--signoffoption of git commit.mainfromfork:branchname