Enhancement certificate validation#413
Draft
StjepanovicSrdjan wants to merge 18 commits into
Draft
Conversation
…m validator to be reusable
…ons, update apidocs
… to n, where 0 is leaf
… TAs, improve api
StjepanovicSrdjan
force-pushed
the
enhancement/certificate-validation
branch
from
324da67 to
65d9220
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #382 - addresses post merge review comments and further api improvements
Update validation API:
AnchoredCertificateChain, containing aCertificateChainand the selectedTrustAnchor.validate()toAnchoredCertificateChain, making it explicit that validation expects a preselected trust anchor and a fixed chain.CertificateChain.buildPathAndValidate(), which uses aChainConstructorinterface to construct all possibleAnchoredCertificateChains and validate them. This enables support for cross-signed trust anchors.Validatorinterface to be stateless by passing the fullAnchoredCertificateChainand validation context toValidator.validate(), instead of invoking validators sequentially per certificate.