Cleanup/alg specific foo - #46
Conversation
|
|
JesusMcCloud
left a comment
JesusMcCloud
left a comment
There was a problem hiding this comment.
Leave the old ones with deprecation marks. Add a changelog entry
| */ | ||
| val X509AlgorithmIdentifier.rsaSsaPssParams: RsaSsaPssParams get() = runRethrowing { | ||
| require(oid == RSA_SSA_PSS_OID) | ||
| DER.decodeFromTlv<RsaSsaPssParams>( |
There was a problem hiding this comment.
Hardcoding DER was cursed from the get-go. Given that this does not have to live inside X509AlgorithmIdentifier any more, we can reshape it from a getter to something else entirely, that properly deserializes
JesusMcCloud
left a comment
JesusMcCloud
left a comment
There was a problem hiding this comment.
Still no changelog, no spotlessApply and no deprecation of the removed functions in X509AlgorithmIdentifier
|
I don't want to leave the deprecated functions on the object itself for shadowing reasons. |
Fair enough. Changelog still missing |
JesusMcCloud
left a comment
JesusMcCloud
left a comment
There was a problem hiding this comment.
Pending the changelog indentation
| * Previously, it took a `List` that could only reasonably have 0-1 elements, enforced by the `parameters` getter. Deprecated that constructor variant. | ||
| * Clean up algorithm-specific parsers and move them out of the generic element they parse | ||
| * `RsaSsaPssParams`: | ||
| * `X509AlgorithmIdentifier.rsaSsaPssParams` -> `RsaSsaPssParams.of(X509AlgorithmIdentifier)` | ||
| * new extension on `RsaSsaPssParams` companion: `X509AlgorithmIdentifier.of(RsaSsaPssParams)` | ||
| * `EcdsaSigValue`: | ||
| * new class: `EcdsaSigValue` models `ECDSA-Sig-Value` from RFC 5480 | ||
| * `X509SignatureValue.decodeRS()` in class -> `X509SignatureValue.toEcdsaSigValue()` on `EcdsaSigValue` companion | ||
| * `X509SignatureValue.fromRS()` -> `EcdsaSigValue.toX509SignatureValue()` |
There was a problem hiding this comment.
Needs four spaces indentation per nested level, otherwise it will not render correctly in the HMTL docs
2 participants
closes #44