docs: 收口 #1390 P7 决策信号文档与 Web i18n - #1727
Merged
ZhuLinsen merged 1 commit intoJun 20, 2026
Merged
Conversation
🤖 自动审查报告
📁 修改的文件
... 还有 3 个文件 🧠 AI 代码审查意见结论: Ready to Merge 结构化审查结果:
|
massif-01
force-pushed
the
massif/1390-p7-decision-signal-closeout
branch
from
June 20, 2026 01:22
cae6467 to
5ace9d3
Compare
massif-01
marked this pull request as ready for review
June 20, 2026 01:34
13 tasks
ZhuLinsen
reviewed
Jun 20, 2026
ZhuLinsen
left a comment
Owner
There was a problem hiding this comment.
评审结论
- 必要性:通过,#1390 P7 需要把 DecisionSignal 文档、Web i18n 展示边界和回归测试收口。
- 是否有对应 issue:有,Refs #1390。
- PR 类型:fix,实际改动包含 Web enum/raw value 展示修复,并配套 docs/test。
- description 完整性:不完整,验证、兼容性和回滚说明基本齐全,但 Web UI 改动的截图证据使用
/private/tmp/...本地路径,GitHub PR 中不可访问。 - 是否可直接合入:不可,需先补充可访问的 UI 视觉证据;CI 当前为 success,
mergeable_state=blocked本身不作为阻断点。
主要问题
- [Process blocker] PR 描述 / Visual Evidence:本 PR 修改了
DecisionSignalsPage、DecisionSignalDisplay、ReportDecisionSignals、PortfolioPage等 Web UI 展示路径。按AGENTS.md,Web UI 改动必须在 PR 描述、PR 评论、GitHub 附件、Actions artifact 或外部可访问链接中附受影响页面截图;当前给出的/private/tmp/dsa-pr1390-p7-web-i18n-*.png是本地路径,reviewer 无法访问,等同未附可验证截图。请上传为 PR 附件/评论或 artifact,或明确说明无法截图并提供替代可视证据。
🤖 此回复由 OpenReview Bot 自动生成,仅供参考。如有疑问请 @维护者。
Collaborator
Author
是误报,截图是有的 |
ZhuLinsen
reviewed
Jun 20, 2026
ZhuLinsen
left a comment
Owner
There was a problem hiding this comment.
评审结论
- 必要性:通过,#1390 P7 需要收口 DecisionSignal 文档、Web i18n 展示边界和防回归测试。
- 是否有对应 issue:有,Refs #1390。
- PR 类型:fix,实际修复 Web raw enum/value 展示问题,并配套 docs/test。
- description 完整性:完整,已覆盖背景、范围、验证命令与结果、可访问截图、兼容性、风险、回滚方案和 EXTRACT_PROMPT 说明,符合 AGENTS.md 对 Web UI 与用户可见变更的交付要求。
- 是否可直接合入:可,阻断型 CI 均为 success,当前描述和截图证据已补齐;结合完整改动文件列表和 diff 摘要,未发现 provider/model/Base URL、默认模型或运行时配置保存/迁移逻辑的实际变更,结构化兼容风险提示不构成本次阻断点。
🤖 此回复由 OpenReview Bot 自动生成,仅供参考。如有疑问请 @维护者。
EchoingFootsteps
pushed a commit
to EchoingFootsteps/daily_stock_analysis
that referenced
this pull request
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Background And Problem
#1390 P7 要求把 DecisionSignal 1.0 前几期能力做最终收口:文档/API/Web 展示/迁移回滚/脱敏边界需要保持一致。P1-P6 已经引入 Web UI 与后端链路,本 PR 不新增运行时能力,只补齐 P7 文档、Web i18n 展示边界和防回归测试,避免用户界面直接裸露 enum/raw value 或设置页出现未本地化配置标题/说明。
Scope Of Change
docs/decision-signals.md,补齐字段语义、API/Web 使用、告警/通知/组合风险/outcome/feedback、脱敏边界、迁移与回滚。docs/full-guide*.md、docs/INDEX*.md、docs/alerts.md、docs/notifications.md、docs/CHANGELOG.md的入口和交叉引用。apps/dsa-web/src/utils/decisionSignalLabels.ts,统一 DecisionSignal 的 market、market phase、horizon、plan quality、source type 本地化 value label。DecisionSignalsPage、DecisionSignalDisplay、ReportDecisionSignals、PortfolioPage的展示路径,避免jp/kr、closing_auction、10d、partial、market_review、sell/reduce/alert等 raw value 直接出现在 UI。action='sell'且旧数据带actionLabel='卖出'时,英文 UI 仍显示Sell。cn/hk/us/jp/kr。Issue Link
Refs #1390
Verification Commands And Results
关键输出/结论:
PortfolioPage26 passed,覆盖旧actionLabel='卖出'在英文 UI 下显示Sell。tests/test_decision_signal_docs.py3 passed,覆盖 OpenAPI market 描述为cn/hk/us/jp/kr。npm run lint:passed。npm run build:passed。git diff --cached --check:passed。git diff --check:passed。PATH=.venv/bin:$PATH ./scripts/ci_gate.sh,结果为3528 passed, 2 deselected, 44 warnings, 322 subtests passed;最终一次 Web-only label helper 调整后补跑了上述 targeted tests/lint/build。Visual Evidence (if applicable)
closing_auction/10d/partial信号;截图断言确认中文页面包含日股、集合竞价、部分,英文页面包含Japan、Closing auction、Partial。PortfolioPageDOM 回归测试覆盖 staleactionLabel反例。Compatibility And Risk
cn/hk/us/jp/kr;不修改数据库 schema、API route、request/response 字段、CLI 参数、环境变量、config registry 或.env.example。Rollback Plan
Revert this PR 即可。回滚不需要额外数据库迁移或配置回滚;历史 DecisionSignal、feedback、outcome 数据不会自动清理,既有报告主流程不受影响。
EXTRACT_PROMPT Change (if applicable)
未修改
src/services/image_stock_extractor.py或EXTRACT_PROMPT。Checklist
docs/CHANGELOG.md;README.md仅在首页级信息变化时更新,细节优先写入docs/*.md/ If user-visible changes are included, relevant docs anddocs/CHANGELOG.mdare updated;README.mdis updated only for homepage-level changes, with details kept indocs/*.md