Skip to content

fix(kuma-config): add retries + lower timeout to stop false-down alerts #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavovalverde merged 6 commits into from
Jul 15, 2026
Merged

fix(kuma-config): add retries + lower timeout to stop false-down alerts #21

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4dd5611
fix(kuma-config): add retries + lower timeout to stop false-down alerts
andres-pcg Jun 26, 2026
5ffcc16
docs(kuma-config): reword retry comment (maxretries, no hard duration)
andres-pcg Jun 26, 2026
852235f
fix(kuma-config): lower default timeout to 15s (< retryInterval)
andres-pcg Jul 6, 2026
cf876a0
docs(kuma-config): clarify maxretries vs timeout roles in comment
andres-pcg Jul 6, 2026
7e9f0d4
refactor(kuma-config): declare monitor tunables explicitly per monitor
andres-pcg Jul 15, 2026
673b827
docs(kuma-config): clarify defaults apply to all monitors; timeout HT…
andres-pcg Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions kuma-config/apply.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,16 @@ function requireEnv(name) {
}

// Fields the `add` handler JSON-stringifies or requires, plus sensible defaults.
// Per-monitor YAML overrides are merged on top of these.
// Per-monitor YAML overrides are merged on top of these. maxretries makes Down
// require several consecutive failures (not a one-off blip) — that's what filters
// the transient timeouts that fired false alerts; the shorter timeout only caps
// how long each attempt waits.
Comment thread
andres-pcg marked this conversation as resolved.
Outdated
const MONITOR_DEFAULTS = {
interval: 60,
retryInterval: 60,
retryInterval: 20,
resendInterval: 0,
maxretries: 0,
timeout: 48,
maxretries: 3,
timeout: 15,
Comment thread
andres-pcg marked this conversation as resolved.
method: "GET",
accepted_statuscodes: ["200-299"],
conditions: [],
Expand Down
24 changes: 0 additions & 24 deletions kuma-config/kuma.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ monitors:
port: 53
dns_resolve_type: A
dns_resolve_server: 1.1.1.1
interval: 60
retryInterval: 60
maxretries: 0
notifications: [Slack]
tags:
- { name: DNS, value: Seeder }
Expand All @@ -57,9 +54,6 @@ monitors:
port: 53
dns_resolve_type: A
dns_resolve_server: 1.1.1.1
interval: 60
retryInterval: 60
maxretries: 0
notifications: [Slack]
tags:
- { name: DNS, value: Seeder }
Expand All @@ -73,9 +67,6 @@ monitors:
port: 53
dns_resolve_type: A
dns_resolve_server: 1.1.1.1
interval: 60
retryInterval: 30
maxretries: 3
notifications: [Slack]
tags:
- { name: DNS, value: Seeder }
Expand All @@ -89,9 +80,6 @@ monitors:
port: 53
dns_resolve_type: A
dns_resolve_server: 1.1.1.1
interval: 60
retryInterval: 30
maxretries: 3
notifications: [Slack]
tags:
- { name: DNS, value: Seeder }
Expand All @@ -105,9 +93,6 @@ monitors:
port: 53
dns_resolve_type: A
dns_resolve_server: 1.1.1.1
interval: 60
retryInterval: 60
maxretries: 0
notifications: [Slack]
tags:
- { name: DNS, value: Seeder }
Expand All @@ -124,9 +109,6 @@ monitors:
type: http
url: ${PROBER_BASE_URL}/status
method: GET
interval: 60
retryInterval: 60
maxretries: 1
notifications: [Slack]
tags:
- { name: DNS, value: Seeder }
Expand All @@ -136,9 +118,6 @@ monitors:
type: http
url: https://zfnd.org/
method: GET
interval: 60
retryInterval: 60
maxretries: 0
expiryNotification: true
notifications: [Slack]
tags:
Expand All @@ -149,9 +128,6 @@ monitors:
type: http
url: https://z.cash/
method: GET
interval: 60
retryInterval: 60
maxretries: 0
expiryNotification: true
notifications: [Slack]
tags:
Expand Down