CI: Make macOS build universal and bump GitHub actions versions#108
Open
shinra-electric wants to merge 3 commits into
Open
CI: Make macOS build universal and bump GitHub actions versions#108shinra-electric wants to merge 3 commits into
shinra-electric wants to merge 3 commits into
Conversation
Author
|
I got an email with a comment, but it seems to have disappeared or has been deleted. Just to confirm, setting the CMake flag does indeed build a universal binary. Running the The compiled executable is available on the action build on my fork for reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
-DCMAKE_OSX_ARCHITECTURES="arm64;x86_64"flag, so CMake will create a universal binary.If x86 support is dropped in the future, this flag can be removed.
Edit:
Also removed the artifact zipping step for macOS and Linux.
The upload-artifact action zips them as well by default, so they were being double-zipped.