SALVL: Object Definitions for SA2 Objects - #308
Open
Marswastakenwastaken wants to merge 20 commits into
Open
Conversation
| private Texture[] texs; | ||
|
|
||
|
|
||
| private NJS_MOTION motion_big_normal; |
Contributor
Author
There was a problem hiding this comment.
So I wanted this to be a list of NJS_MOTIONs but I was receiving crashes the way I implemented it so for now it will just be individual motions and a switch statement.
pkr-sadx
reviewed
Mar 15, 2026
| meshes = ObjectHelper.GetMeshes(object_big); | ||
| texlist_big = NJS_TEXLIST.Load("enemy/big/tls/BIG.satex"); | ||
|
|
||
| motion_big_normal = NJS_MOTION.Load("enemy/big/Big1.saanim"); |
There was a problem hiding this comment.
Pls do not load motions from files directly in the object definition, use ObjectHelper.LoadMotion that I just added.
Marswastakenwastaken
force-pushed
the
master
branch
from
March 27, 2026 18:12
447d889 to
fbc8b04
Compare
That is unfinished work and it doesn't need a code file anymore.
Marswastakenwastaken
marked this pull request as ready for review
April 1, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on some objects for the SA2 side of SALVL which needed some code changes. I believe some more work needs to be done here before it can be merged.